chore(number input): img updates#4624
Merged
Merged
Conversation
Collaborator
Contributor
There was a problem hiding this comment.
the "Increments by _" text is a little hard to tie to the specific inputs because of the placement. would it look better to move them above and left align? or maybe add a new # annotation that points to both and explains the different increments?
Collaborator
There was a problem hiding this comment.
++ Agree that adding those captions as titles would be helpful (like in https://patternfly-org-pr-4624-site.surge.sh/components/alert/design-guidelines#alerts)
bekah-stephens
approved these changes
May 20, 2025
edonehoo
approved these changes
May 20, 2025
Collaborator
edonehoo
left a comment
edonehoo
left a comment
There was a problem hiding this comment.
Outside of maybe changing the pink captions to black headers, this looks good 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4559