-
Notifications
You must be signed in to change notification settings - Fork 148
chore(number input): img updates #4624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file removed
BIN
-36.6 KB
.../content/design-guidelines/components/number input/img/number_input_anatomy.png
Binary file not shown.
57 changes: 57 additions & 0 deletions
57
.../content/design-guidelines/components/number input/img/number_input_anatomy.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file removed
BIN
-32.3 KB
...s/content/design-guidelines/components/number input/img/number_input_states.png
Binary file not shown.
49 changes: 49 additions & 0 deletions
49
...s/content/design-guidelines/components/number input/img/number_input_states.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file removed
BIN
-18.9 KB
...y-docs/content/design-guidelines/components/number input/img/with_threshold.png
Binary file not shown.
37 changes: 37 additions & 0 deletions
37
...y-docs/content/design-guidelines/components/number input/img/with_threshold.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the "Increments by _" text is a little hard to tie to the specific inputs because of the placement. would it look better to move them above and left align? or maybe add a new # annotation that points to both and explains the different increments?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++ Agree that adding those captions as titles would be helpful (like in https://patternfly-org-pr-4624-site.surge.sh/components/alert/design-guidelines#alerts)