Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import styles from '@patternfly/react-styles/css/components/DualListSelector/dua
import { css } from '@patternfly/react-styles';
import { DualListSelectorTreeItemData } from './DualListSelectorTree';
import { Badge } from '../Badge';
import RhMicronsCaretDownIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-down-icon';
import RhMicronsCaretRightIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-right-icon';
import { flattenTree } from './treeUtils';
import { DualListSelectorListContext } from './DualListSelectorContext';
import { useHasAnimations } from '../../helpers';
Expand Down Expand Up @@ -136,7 +136,7 @@ const DualListSelectorTreeItemBase: React.FunctionComponent<DualListSelectorTree
tabIndex={-1}
>
<span className={css(styles.dualListSelectorItemToggleIcon)}>
<RhMicronsCaretDownIcon />
<RhMicronsCaretRightIcon />
</span>
</div>
)}
Expand Down
2 changes: 1 addition & 1 deletion packages/react-core/src/components/Hero/Hero.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ export const Hero: React.FunctionComponent<HeroProps> = ({
bodyWidth,
bodyMaxWidth,
...props
}) => {
}: HeroProps) => {
const customStyles: { [key: string]: string } = {};
if (backgroundSrcLight) {
customStyles[heroBackgroundImageLight.name] = `url(${backgroundSrcLight})`;
Expand Down
8 changes: 5 additions & 3 deletions packages/react-core/src/components/Popover/Popover.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -205,9 +205,11 @@ export interface PopoverProps {
shouldOpen?: (event: MouseEvent | KeyboardEvent, showFunction?: () => void) => void;
/** Flag indicating whether the close button should be shown. */
showClose?: boolean;
/** Sets an interaction to open popover, defaults to "click" */
/** @deprecated Sets an interaction to open popover, defaults to "click" */
triggerAction?: 'click' | 'hover';
/** Whether to trap focus in the popover. */
/** Whether to trap focus in the popover. When using a triggerAction of "hover", this will be set to false
* by default and must remain false.
*/
withFocusTrap?: boolean;
/** The z-index of the popover. */
zIndex?: number;
Expand Down Expand Up @@ -267,7 +269,7 @@ export const Popover: React.FunctionComponent<PopoverProps> = ({
],
animationDuration = 300,
id,
withFocusTrap: propWithFocusTrap,
withFocusTrap: propWithFocusTrap = triggerAction === 'hover' ? false : undefined,
triggerRef,
hasNoPadding = false,
hasAutoWidth = false,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,11 @@ By default, the `appendTo` prop of the popover will append to the document body

### Hoverable

```ts file="./PopoverHover.tsx"
Pass the `triggerAction="hover"` property to make a `<Popover>` that is triggered via hover and focus rather than on click. When using a hoverable Popover, you **must not** include any interactive or semantic content (e.g. buttons, links, headings, lists, etc), as focus is not intended to enter a hoverable `<Popover>`. Including such content may cause an inaccessible UI for users who are not able to reach the content when navigating via assistive tech.

It is instead recommended to use our [tooltip component](/components/tooltip).

```ts isDeprecated file="./PopoverHover.tsx"

```

Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { memo, useState, useEffect, Children, isValidElement, cloneElement } from 'react';
import { css } from '@patternfly/react-styles';
import styles from '@patternfly/react-styles/css/components/TreeView/tree-view';
import RhMicronsCaretDownIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-down-icon';
import RhMicronsCaretRightIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-right-icon';
import { TreeViewDataItem } from './TreeView';
import { Badge } from '../Badge';
import { useSSRSafeId } from '../../helpers';
Expand Down Expand Up @@ -155,7 +155,7 @@ const TreeViewListItemBase: React.FunctionComponent<TreeViewListItemProps> = ({
tabIndex={-1}
>
<span className={css(styles.treeViewNodeToggleIcon)}>
<RhMicronsCaretDownIcon />
<RhMicronsCaretRightIcon />
</span>
</ToggleComponent>
);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ exports[`Matches snapshot with children 1`] = `
width="1em"
>
<path
d="M18.71 5.29a.996.996 0 0 0-1.41 0l-7.29 7.29-7.3-7.29a.987.987 0 0 0-1.41-.02.987.987 0 0 0-.02 1.41l.02.02 7.65 7.65c.29.29.68.44 1.06.44s.77-.15 1.06-.44l7.65-7.65a.996.996 0 0 0 0-1.41Z"
d="M14.35 8.94 6.71 1.29l-.02-.02c-.4-.38-1.03-.37-1.41.02-.38.4-.37 1.03.02 1.41l7.29 7.29-7.29 7.29a1.003 1.003 0 0 0 1.42 1.42l7.65-7.65c.59-.59.59-1.54 0-2.12Z"
/>
</svg>
</span>
Expand Down
2 changes: 1 addition & 1 deletion packages/react-docs/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"victory": "^37.3.6"
},
"devDependencies": {
"@patternfly/documentation-framework": "^6.36.8",
"@patternfly/documentation-framework": "^6.40.0",
"@patternfly/patternfly-a11y": "5.1.0"
},
"keywords": [
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import styles from '@patternfly/react-styles/css/components/Table/table';
import stylesTreeView from '@patternfly/react-styles/css/components/Table/table-tree-view';
import { Button } from '@patternfly/react-core/dist/esm/components/Button';
import { Checkbox } from '@patternfly/react-core/dist/esm/components/Checkbox';
import RhMicronsCaretDownIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-down-icon';
import RhMicronsCaretRightIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-right-icon';
import RhUiEllipsisHorizontalFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-ellipsis-horizontal-fill-icon';

export const treeRow =
Expand Down Expand Up @@ -54,7 +54,7 @@ export const treeRow =
aria-label={toggleAriaLabel || `${isExpanded ? 'Collapse' : 'Expand'} row ${rowIndex}`}
icon={
<div className={css(stylesTreeView.tableToggleIcon)}>
<RhMicronsCaretDownIcon />
<RhMicronsCaretRightIcon />
</div>
}
/>
Expand Down
20 changes: 10 additions & 10 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -4963,9 +4963,9 @@ __metadata:
languageName: node
linkType: hard

"@patternfly/documentation-framework@npm:^6.36.8":
version: 6.36.8
resolution: "@patternfly/documentation-framework@npm:6.36.8"
"@patternfly/documentation-framework@npm:^6.40.0":
version: 6.49.2
resolution: "@patternfly/documentation-framework@npm:6.49.2"
dependencies:
"@babel/core": "npm:^7.29.0"
"@babel/preset-env": "npm:7.29.0"
Expand Down Expand Up @@ -5026,16 +5026,16 @@ __metadata:
webpack-dev-server: "npm:5.2.3"
webpack-merge: "npm:5.10.0"
peerDependencies:
"@patternfly/patternfly": ^6.5.0-prerelease.46
"@patternfly/react-code-editor": ^6.5.0-prerelease.39
"@patternfly/react-core": ^6.5.0-prerelease.36
"@patternfly/react-icons": ^6.5.0-prerelease.15
"@patternfly/react-table": ^6.5.0-prerelease.37
"@patternfly/patternfly": ^6.6.0
"@patternfly/react-code-editor": ^6.6.0
"@patternfly/react-core": ^6.6.0
"@patternfly/react-icons": ^6.6.0
"@patternfly/react-table": ^6.6.0
react: ^17.0.0 || ^18.0.0
react-dom: ^17.0.0 || ^18.0.0
bin:
pf-docs-framework: scripts/cli/cli.js
checksum: 10c0/bf29256be06e32e130d6146a8d5cc9744e0b88463b69f9c2ef6bae98f0ffee15901760fb69c3737d7fdcf2d612511d034c7661568c92187ead143fe772f8d561
checksum: 10c0/1d80d9d6078237d17b71deeb4ffa4b7ad6ed43c0d424c6044de4420d5ef8267eb913e281fc97ffa9fe6d6e70b0462557c22fdf50ecca9df555163eb48ab40ff5
languageName: node
linkType: hard

Expand Down Expand Up @@ -5191,7 +5191,7 @@ __metadata:
version: 0.0.0-use.local
resolution: "@patternfly/react-docs@workspace:packages/react-docs"
dependencies:
"@patternfly/documentation-framework": "npm:^6.36.8"
"@patternfly/documentation-framework": "npm:^6.40.0"
"@patternfly/patternfly": "npm:^6.6.0"
"@patternfly/patternfly-a11y": "npm:5.1.0"
"@patternfly/react-charts": "workspace:^"
Expand Down
Loading