Fix and refactor get_histogram_timings#664
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #664 +/- ##
==========================================
- Coverage 86.46% 86.31% -0.15%
==========================================
Files 3 3
Lines 1345 1345
Branches 217 218 +1
==========================================
- Hits 1163 1161 -2
- Misses 86 87 +1
- Partials 96 97 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jeltz
approved these changes
Jun 5, 2026
Contributor
jeltz
left a comment
jeltz
left a comment
There was a problem hiding this comment.
Looks great but had one small improvement you can optionally do.
jeltz
reviewed
Jun 5, 2026
Use of StringInfoData type to build resulting string fixes overflow for big amount of buckets. Now output is valid for any buckets amount.
artemgavrilov
force-pushed
the
refactoring
branch
from
9c30e08 to
aee64c2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use of StringInfoData type to build resulting string fixes overflow for big amount of buckets. Now output is valid for any buckets amount.
PG-0
Description
Links