Skip to content

Fix and refactor get_histogram_timings #664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
artemgavrilov merged 1 commit into from
Jun 5, 2026
Merged

Fix and refactor get_histogram_timings #664

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 22 additions & 23 deletions pg_stat_monitor.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2964,8 +2964,6 @@ comp_location(const void *a, const void *b)
return 0;
}

#define MAX_STRING_LEN 1024

/* Convert array of integers into Text datum */
static Datum
intarray_get_datum(int32 arr[], int len)
Expand Down Expand Up @@ -3179,36 +3177,37 @@ get_histogram_bucket(double q_time)
Datum
get_histogram_timings(PG_FUNCTION_ARGS)
{
double b_start;
double b_end;
int b_count = hist_bucket_count_total;
int index = 0;
char *tmp_str = palloc0(MAX_STRING_LEN);
char *text_str = palloc0(MAX_STRING_LEN);
Comment thread
artemgavrilov marked this conversation as resolved.
StringInfoData buf;

initStringInfo(&buf);

for (index = 0; index < b_count; index++)
appendStringInfoChar(&buf, '{');

for (int index = 0; index < hist_bucket_count_total; index++)
{
double b_start;
double b_end;

histogram_bucket_timings(index, &b_start, &b_end);

if (index == 0)
{
snprintf(text_str, MAX_STRING_LEN, "{{%.3lf - %.3lf}", b_start, b_end);
}
else if (index == (b_count - 1))
{
snprintf(tmp_str, MAX_STRING_LEN, "%s, (%.3lf - ...}}", text_str, b_start);
snprintf(text_str, MAX_STRING_LEN, "%s", tmp_str);
}
appendStringInfoChar(&buf, '{');
else
{
snprintf(tmp_str, MAX_STRING_LEN, "%s, (%.3lf - %.3lf}", text_str, b_start, b_end);
snprintf(text_str, MAX_STRING_LEN, "%s", tmp_str);
}
appendStringInfoString(&buf, ", (");

appendStringInfo(&buf, "%.3f - ", b_start);

if (b_end == -1)
appendStringInfoString(&buf, "...");
else
appendStringInfo(&buf, "%.3f", b_end);

appendStringInfoChar(&buf, '}');
}

pfree(tmp_str);
appendStringInfoChar(&buf, '}');

return CStringGetTextDatum(text_str);
return CStringGetTextDatum(buf.data);
}


Expand Down
Loading