test(engine): lock chained explore resume after DigChoice (#1151)

[kiannidev]

Summary

• Add regression test ensuring a chained second Explore resumes only after the first explore's nonland DigChoice completes (Jadelight Ranger pattern).

Test plan

• cargo test -p engine --lib chained_explore_resumes

Fixes #1151

[gemini-code-assist]

Code Review

This pull request adds a unit test to crates/engine/src/game/effects/explore.rs to verify that chained explore abilities resume correctly after a nonland DigChoice resolves. The feedback suggests optimizing the test by matching on a reference to state.waiting_for instead of cloning it, which avoids unnecessary heap allocations.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[gemini-code-assist]

[MEDIUM] Avoid unnecessary cloning of WaitingFor by matching on a reference.

Why it matters: WaitingFor is a large enum containing heap-allocated collections (like Vec<ObjectId> and Vec<String>). Cloning it just to extract a single ObjectId from the cards vector is inefficient.

Suggested fix: Match on &state.waiting_for instead of state.waiting_for.clone().

Suggested change

	let WaitingFor::DigChoice { cards, .. } = state.waiting_for.clone() else {
	let WaitingFor::DigChoice { cards, .. } = &state.waiting_for else {

[matthewevans]

VERDICT: approve-pending-CI

Reviewed head ea76fc02249ac59432545731f04d9bcde0f3e593, then pushed maintainer fixup 9686b12c885e117da62ab8953fba7ef862a796b1 to move the new test imports to module scope.

The regression is at the right seam: it drives resolve_ability_chain through the real nonland explore DigChoice pause and then resolves the player action through engine::apply_as_current, so it would fail if the chained second explore were not preserved across the first choice. Local pre-push passed fmt, clippy, card-data validate, parser gate, engine parser tests, and phase-ai tests; it failed only at local oracle-gen because data/mtgjson/AtomicCards.json is absent.

Holding formal approval/enqueue until CI is green on the pushed head and the branch is brought current / passes the normal repush guard.

[matthewevans]

Approved after re-review of the current head: this is a test-only regression at the chained explore/DigChoice resume seam, the required test label is present, and GitHub checks are green at 81e137c075b00d3644a5cd7ce8ba7d1666d832a8.