-
-
Notifications
You must be signed in to change notification settings - Fork 87
test(engine): lock chained explore resume after DigChoice (#1151) #3740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
matthewevans
merged 7 commits into
phase-rs:main
from
kiannidev:fix/issue-1151-jadelight-explore
Jun 18, 2026
+83
−0
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
e90975b
test(engine): lock chained explore resume after DigChoice (#1151)
kiannidev f42ed23
merge upstream/main
kiannidev ea76fc0
style(engine): format explore regression test for CI
kiannidev 9686b12
style(engine): move explore test imports to module scope
matthewevans ee1f364
Merge branch 'main' into fix/issue-1151-jadelight-explore
matthewevans 44cbef8
Merge branch 'main' into fix/issue-1151-jadelight-explore
matthewevans 81e137c
Merge branch 'main' into fix/issue-1151-jadelight-explore
matthewevans File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[MEDIUM] Avoid unnecessary cloning of
WaitingForby matching on a reference.Why it matters:
WaitingForis a large enum containing heap-allocated collections (likeVec<ObjectId>andVec<String>). Cloning it just to extract a singleObjectIdfrom thecardsvector is inefficient.Suggested fix: Match on
&state.waiting_forinstead ofstate.waiting_for.clone().