Change normal and visual mode behavior more strict#8
Open
gitusp wants to merge 2 commits intophilc:masterfrom
Open
Change normal and visual mode behavior more strict#8gitusp wants to merge 2 commits intophilc:masterfrom
gitusp wants to merge 2 commits intophilc:masterfrom
Conversation
This change was made to prevent accidentally input a random character like "w" or "b".
Since 7acf795 change the behavior to ignore all the unassigned keys.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It changes normal and visual mode behavior to cancel all the unassigned characters, to prevent accidentally input an unassigned(but exists in vim) character like "w" or "b". I thought no-op is better than accidental input.
It does not cancel a key event if the key is pressed with ctrl or meta, not to mask Google Sheets' default shortcuts such as ⌘-F.
It also adds explicit arrow key mappings to prevent canceling them because of the above change.