Skip to content

Change normal and visual mode behavior more strict #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gitusp wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Change normal and visual mode behavior more strict #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f3226a7
Change normal and visual* mode behavior more strict
gitusp Oct 2, 2020
c7e1517
Assign arrow keys explicitly
gitusp Oct 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions content_scripts/commands.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,10 @@ Commands = {
"j": "moveDown",
"h": "moveLeft",
"l": "moveRight",
"up": "moveUp",
"down": "moveDown",
"left": "moveLeft",
"right": "moveRight",

// Row & column movement
"<C-J>": "moveRowsDown",
Expand Down
13 changes: 13 additions & 0 deletions content_scripts/ui.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,8 +231,21 @@ UI = {
this.keyQueue = [];
this.cancelEvent(e);
Commands.commands[commandName].fn();
return;
}
}

// Cancel the event if the mode matches "normal" or "visual*",
// to prevent accidentally input an unassigned character like "w" or "b".
// Ensure that the key is not pressed with ctrl or meta,
// not to mask Google Sheets' default shortcuts such as ⌘-F.
if (
!e.ctrlKey &&
!e.metaKey &&
["normal", "visual", "visualLine", "visualColumn"].includes(this.mode)
) {
this.cancelEvent(e);
}
},

// modifiers: optiona; an object with these boolean properties: meta, shift, control.
Expand Down