gmagick/setup.xml: add the missing dot character#3542
Closed
mmalferov wants to merge 1 commit intophp:masterfrom
Closed
gmagick/setup.xml: add the missing dot character#3542mmalferov wants to merge 1 commit intophp:masterfrom
mmalferov wants to merge 1 commit intophp:masterfrom
Conversation
Girgias
reviewed
Jul 26, 2024
| <para> | ||
| For Windows, the build of the Gmagick extension is available | ||
| <link xlink:href="&url.gmagick.winbuilds;">here</link> | ||
| <link xlink:href="&url.gmagick.winbuilds;">here</link>. |
Member
There was a problem hiding this comment.
Maybe changing the "here" would also be a good idea, as I don't think this follows industry best practises
Member
There was a problem hiding this comment.
Right. And that site appears to be down, anyway. Might be best to support gmagick builds via https://github.com/php/php-windows-builder, and to refer to PECL as usual.
Member
There was a problem hiding this comment.
Ugh, easier said than done. Would need something like vitoc/gmagick#60, and apparently, php-windows-builder doesn't run pre-releases, but gmagick apparently never had a stable release, and the project looks somewhat unmaintained.
Maybe just drop that paragraph?
Member
|
Resolved via 330dda4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.