Skip to content

gmagick/setup.xml: add the missing dot character #3542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mmalferov wants to merge 1 commit into from
Closed

gmagick/setup.xml: add the missing dot character #3542

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion reference/gmagick/setup.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
</note>
<para>
For Windows, the build of the Gmagick extension is available
<link xlink:href="&url.gmagick.winbuilds;">here</link>
<link xlink:href="&url.gmagick.winbuilds;">here</link>.
Copy link
Copy Markdown
Member

@Girgias Girgias Jul 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe changing the "here" would also be a good idea, as I don't think this follows industry best practises

Copy link
Copy Markdown
Member

@cmb69 cmb69 Jul 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. And that site appears to be down, anyway. Might be best to support gmagick builds via https://github.com/php/php-windows-builder, and to refer to PECL as usual.

Copy link
Copy Markdown
Member

@cmb69 cmb69 Oct 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh, easier said than done. Would need something like vitoc/gmagick#60, and apparently, php-windows-builder doesn't run pre-releases, but gmagick apparently never had a stable release, and the project looks somewhat unmaintained.

Maybe just drop that paragraph?

</para>
</section>
<!-- }}} -->
Expand Down