Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is conceptually simple, but because of the nuances of Python's typing system and class construction, it is actually a bit challenging to implement correctly.
We want to support custom type-hinting subclasses that give static type checkers like
mypy,pyright, andtyadditional power to flag errors before we hit runtime. One motivating example is foreign-key correctness.Right now, all ID fields collapse down to plain UUIDs:
From the type checker’s perspective, these are all interchangeable. That means code like this looks valid:
Even though both assignments are obviously wrong at the schema level, static analysis has no way to detect it because everything is just
UUID.This PR allows us to introduce semantically distinct ID types:
Now the same incorrect code becomes visible to the type checker:
That is the core goal of this PR: preserve the existing runtime behavior while giving static tooling enough structure to understand that not all UUIDs are interchangeable.