PB-3743: 0-9: Update restpack_serializer fork for kaminari 1.x#4
Open
Lalo (carlos-perez-wl) wants to merge 2 commits intodevelopfrom
Open
Conversation
…lizer-fork-for-kaminari-1-x
Guillaume Loubier (Loubz)
left a comment
Guillaume Loubier (Loubz)
left a comment
There was a problem hiding this comment.
Let me know what you think Lalo (@carlos-perez-wl)
| gem.add_dependency 'activesupport', ['>= 4.0.3'] | ||
| gem.add_dependency 'activerecord', ['>= 4.0.3'] | ||
| gem.add_dependency 'kaminari', '~> 0.16.1' | ||
| gem.add_dependency 'kaminari', '>= 1.0', '< 2.0' |
There was a problem hiding this comment.
Would it be safer for the upgrade, to still allow the a version before the 1.0 jump to still work (I based my suggestion on this PR where they updated it for Kaminari 1).
Suggested change
| gem.add_dependency 'kaminari', '>= 1.0', '< 2.0' | |
| gem.add_dependency 'kaminari', ['>= 0.17.0', '< 2.0'] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the restpack_serializer fork to support Kaminari 1.x, which is required for Rails 7 compatibility and unblocks Phase 4 of the Rails upgrade.
Changes
Why
Kaminari 0.16.x is incompatible with modern Rails. This upgrade resolves the dependency blocker with minimal, low‑risk changes.
Risk
Low — only public, stable Kaminari APIs are used; no API or contract changes.