Skip to content

PB-3743: 0-9: Update restpack_serializer fork for kaminari 1.x #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Lalo (carlos-perez-wl) wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

PB-3743: 0-9: Update restpack_serializer fork for kaminari 1.x #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a50b553
PB-3743: update kaminari dependency to version 1.x and bump version t…
carlos-perez-wl Mar 17, 2026
e238542
Merge branch 'develop' into feature/PB-3743-0-9-update-restpack-seria…
carlos-perez-wl Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions lib/restpack_serializer.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@
require 'restpack_serializer/factory'
require 'restpack_serializer/result'

Kaminari::Hooks.init

module RestPack
module Serializer
mattr_accessor :config
Expand Down
2 changes: 1 addition & 1 deletion lib/restpack_serializer/version.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
module RestPack
module Serializer
VERSION = '0.5.9'
VERSION = '0.6.0'
end
end
2 changes: 1 addition & 1 deletion restpack_serializer.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ Gem::Specification.new do |gem|

gem.add_dependency 'activesupport', ['>= 4.0.3']
gem.add_dependency 'activerecord', ['>= 4.0.3']
gem.add_dependency 'kaminari', '~> 0.16.1'
gem.add_dependency 'kaminari', '>= 1.0', '< 2.0'
Copy link
Copy Markdown

@Loubz Guillaume Loubier (Loubz) Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be safer for the upgrade, to still allow the a version before the 1.0 jump to still work (I based my suggestion on this PR where they updated it for Kaminari 1).

Suggested change
gem.add_dependency 'kaminari', '>= 1.0', '< 2.0'
gem.add_dependency 'kaminari', ['>= 0.17.0', '< 2.0']


gem.add_development_dependency 'restpack_gem', '~> 0.0.9'
gem.add_development_dependency 'rake', '~> 10.0.3'
Expand Down