keyspacepb: split namespace service - #1505
Merged
Merged
Conversation
Signed-off-by: disksing <i@disksing.com>
ti-chi-bot
Bot
added
the
size/XL
ti-chi-bot
Bot
added
do-not-merge/needs-linked-issue
and removed
do-not-merge/needs-linked-issue
labels
rleungx
approved these changes
Jul 24, 2026
ti-chi-bot
Bot
added
needs-1-more-lgtm
niubell
approved these changes
Jul 24, 2026
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: niubell, rleungx The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
Bot
added
lgtm
and removed
needs-1-more-lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #1506
Follow-up to #1458 and the review discussion. Namespace RPCs are currently exposed by the
Keyspaceservice even though namespace is a separate parent resource.What is changed and how it works?
Namespaceservice for namespace lifecycle RPCs.Keyspaceservice.proto.lock.This changes the namespace RPC method names from
keyspacepb.Keyspace/*Namespace*tokeyspacepb.Namespace/*Namespace*.Tests
make checkgo build ./pkg/...go test ./...git diff --check