Skip to content

br: complete the list of unrecoverable tables - #52531

Merged
ti-chi-bot[bot] merged 3 commits into
pingcap:masterfrom
Leavrth:unrecoverable_system_tables
Jan 24, 2025
Merged

br: complete the list of unrecoverable tables#52531
ti-chi-bot[bot] merged 3 commits into
pingcap:masterfrom
Leavrth:unrecoverable_system_tables

Conversation

@Leavrth

@Leavrth Leavrth commented Apr 12, 2024

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: close #52530

Problem Summary:
we need to complete the list of unrecoverable tables.

What changed and how does it work?

complete the list of unrecoverable tables.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
@ti-chi-bot ti-chi-bot Bot added do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/needs-tests-checked labels Apr 12, 2024
@tiprow

tiprow Bot commented Apr 12, 2024

Copy link
Copy Markdown

Hi @Leavrth. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov

codecov Bot commented Apr 12, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.1441%. Comparing base (5ed9e63) to head (d427956).
Report is 50 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #52531        +/-   ##
================================================
+ Coverage   73.0400%   76.1441%   +3.1041%     
================================================
  Files          1684       1706        +22     
  Lines        465705     483927     +18222     
================================================
+ Hits         340151     368482     +28331     
+ Misses       104635      93362     -11273     
- Partials      20919      22083      +1164     
Flag Coverage Δ
integration 47.6040% <100.0000%> (?)
unit 73.7108% <0.0000%> (+1.4821%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 62.9178% <100.0000%> (+17.6080%) ⬆️

@ti-chi-bot ti-chi-bot Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 5, 2024
@ti-chi-bot

ti-chi-bot Bot commented Jul 5, 2024

Copy link
Copy Markdown

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot Bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 20, 2025
@ti-chi-bot

ti-chi-bot Bot commented Jan 21, 2025

Copy link
Copy Markdown

@BornChanger: Your lgtm message is repeated, so it is ignored.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot

ti-chi-bot Bot commented Jan 24, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, BornChanger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 24, 2025
@ti-chi-bot

ti-chi-bot Bot commented Jan 24, 2025

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2025-01-20 09:07:29.66628027 +0000 UTC m=+85376.997199672: ☑️ agreed by BornChanger.
  • 2025-01-24 08:33:57.099346346 +0000 UTC m=+428964.430265735: ☑️ agreed by 3pointer.

@BornChanger

Copy link
Copy Markdown
Contributor

/retest

@tiprow

tiprow Bot commented Jan 24, 2025

Copy link
Copy Markdown

@BornChanger: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot
ti-chi-bot Bot merged commit 4b98d4e into pingcap:master Jan 24, 2025
zeminzhou pushed a commit to zeminzhou/tidb that referenced this pull request May 6, 2025
@YuJuncen YuJuncen added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Jul 20, 2026
@ti-chi-bot

Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #69947.
But this PR has conflicts, please resolve them!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

system table backup/restore

5 participants