*: update kvproto to apiv3#69942
Conversation
Signed-off-by: disksing <i@disksing.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
📝 WalkthroughWalkthroughThis change updates kvproto, TiKV, and PD dependency pins; migrates keyspace protobuf usage to oneof wrappers and getter accessors; adds mock keyspace identity methods; and updates affected production code and tests. ChangesKeyspace protobuf migration
Estimated code review effort: 2 (Simple) | ~15 minutes Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #69942 +/- ##
================================================
- Coverage 76.3194% 75.5590% -0.7604%
================================================
Files 2041 2086 +45
Lines 559924 582748 +22824
================================================
+ Hits 427331 440319 +12988
- Misses 131692 140285 +8593
- Partials 901 2144 +1243
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
What problem does this PR solve?
Issue Number: close #69944
Problem Summary:
The kvproto APIV3 branch changes keyspace and AutoID protobuf fields to oneofs. TiDB needs compatible kvproto, client-go, and PD client revisions together with source updates for the generated APIs.
What changed and how does it work?
Check List
Tests
make bazel_preparemake bazel_binmake lintgo test -tags=intest ./pkg/autoid_service -run '^TestAPI$' -count=1./tools/check/failpoint-go-test.sh pkg/meta/autoid -run '^TestUnsignedAutoid$' -count=1go test ./pkg/store/mockstore/unistoreSide effects
Documentation
Release note
Summary by CodeRabbit
Dependency Updates
Bug Fixes
Tests