fix(desktop): keep release notes visible while downloading - #6412
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Approved 8e3addc This is a targeted UI fix that changes the disabled state implementation from native HTML You can customize Macroscope's approvability policy. Learn more. |
What Changed
Keep the desktop update pill's release notes popout hoverable and focusable while an update is downloading. The control retains its disabled styling and ARIA state, and its existing action guard still prevents duplicate downloads.
Why
A native
disabledbutton does not receive the pointer or focus events the tooltip needs, so nightly patch notes disappeared for the duration of a download. Usingaria-disabledwith explicit disabled styling preserves the non-actionable state without blocking the popout.UI Changes
Before: The downloading button could not reveal the patch-notes popout.
After: Patch notes remain available while the button shows download progress and stays non-actionable.
Checklist
Verification
vp test run src/components/desktopUpdate.logic.test.ts --project unitvp run typecheckBuilt with GPT-5.6-Sol in the Codex harness via T3 Code.
Note
Low Risk
Single UI control change with preserved click guards; no auth, data, or backend impact.
Overview
The sidebar desktop update pill no longer uses the native
disabledattribute on its control button. It now drives non-actionable state witharia-disabled, aninteractionDisabledflag (existing disabled logic plus pending actions), and explicit opacity/cursor/hover classes so it still looks and behaves disabled.handleActionstill bails when interactions are disabled, so duplicate downloads/installs are not triggered. The change is specifically so hover/focus can reach the button (and the nightly release notes tooltip) while a download is in progress—something a truly disabled button blocks.Reviewed by Cursor Bugbot for commit 8e3addc. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Keep release notes visible in
SidebarUpdateControlwhile downloadingRemoves the native
disabledattribute from the update button in SidebarUpdatePill.tsx so the button stays focusable and visible during download. Non-interactive state is now expressed viaaria-disabledand conditional Tailwind classes (cursor-not-allowed,opacity-60) rather than the browser's built-in disabled behavior.Macroscope summarized 8e3addc.