Skip to content

fix(desktop): keep release notes visible while downloading #6412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
extoci wants to merge 1 commit into
base: main
Choose a base branch
from
+15 −7
Open

fix(desktop): keep release notes visible while downloading #6412

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 15 additions & 7 deletions apps/web/src/components/sidebar/SidebarUpdatePill.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,11 +122,12 @@ function SidebarUpdateControl() {
? "Checking for updates…"
: "Check for updates";
const disabled = isUpdateState ? isDesktopUpdateButtonDisabled(state) : !canCheckForUpdate(state);
const interactionDisabled = disabled || isActionPending;

const handleAction = useCallback(async () => {
const bridge = window.desktopBridge;
if (!bridge || !state) return;
if (disabled || isActionPending) return;
if (interactionDisabled) return;

setIsActionPending(true);

Expand Down Expand Up @@ -232,7 +233,7 @@ function SidebarUpdateControl() {
);
})
.finally(() => setIsActionPending(false));
}, [action, disabled, isActionPending, state]);
}, [action, interactionDisabled, state]);

return (
<SidebarMenuItem className="ml-auto shrink-0">
Expand All @@ -242,13 +243,20 @@ function SidebarUpdateControl() {
<button
type="button"
aria-label={tooltip}
aria-disabled={disabled || isActionPending || undefined}
disabled={disabled || isActionPending}
aria-disabled={interactionDisabled || undefined}
className={cn(
"inline-flex size-8 items-center justify-center rounded-full outline-hidden ring-ring transition-colors enabled:cursor-pointer focus-visible:ring-2 disabled:cursor-not-allowed disabled:opacity-60",
"inline-flex size-8 items-center justify-center rounded-full outline-hidden ring-ring transition-colors focus-visible:ring-2",
interactionDisabled ? "cursor-not-allowed opacity-60" : "cursor-pointer",
isUpdateState
? "bg-update-surface text-update-foreground enabled:hover:bg-update/12"
: "text-[var(--sidebar-icon-color)] enabled:hover:bg-sidebar-row-hover enabled:hover:text-sidebar-foreground",
? cn(
"bg-update-surface text-update-foreground",
!interactionDisabled && "hover:bg-update/12",
)
: cn(
"text-[var(--sidebar-icon-color)]",
!interactionDisabled &&
"hover:bg-sidebar-row-hover hover:text-sidebar-foreground",
),
)}
onClick={handleAction}
>
Expand Down
Loading