APIv2: visit:country_name, visit:region_name, visit:city_name dimensions#4328
Merged
APIv2: visit:country_name, visit:region_name, visit:city_name dimensions#4328
Conversation
…name dimensions Under the hood this relies on a `location_data` table in clickhouse being regularly synced with plausible/location repo and dictionary lookups used in ALIAS columns
macobo
commented
Jul 9, 2024
aerosol
reviewed
Jul 10, 2024
priv/ingest_repo/migrations/20240709181437_populate_location_data.exs
Outdated
Show resolved
Hide resolved
aerosol
reviewed
Jul 10, 2024
aerosol
reviewed
Jul 10, 2024
ukutaht
reviewed
Jul 10, 2024
ruslandoga
reviewed
Jul 10, 2024
ruslandoga
reviewed
Jul 10, 2024
ruslandoga
reviewed
Jul 10, 2024
ruslandoga
reviewed
Jul 10, 2024
test/plausible_web/controllers/api/external_stats_controller/query_imported_test.exs
Show resolved
Hide resolved
Contributor
Author
|
Note: Heading out to vacation. I'll leave it up to @ukutaht whether to push this to production or wait until I'm back whereupon I'll get this merged :) |
RobertJoonas
approved these changes
Aug 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
Note the migrations/app check will fail in this PR - that's expected and OK in this case.
Depends on plausible/location#25