Conversation
aerosol
requested changes
Jul 10, 2024
Member
aerosol
left a comment
aerosol
left a comment
There was a problem hiding this comment.
Change requests inline.
nitpick: modules and functions instead of classes and methods 🙈 - I'm sorry, I'll show myself out
macobo
changed the title
Location.version() methodLocation.version() function
ruslandoga
reviewed
Jul 10, 2024
| def version() do | ||
| version_file = Application.app_dir(:location, "priv/version") | ||
|
|
||
| File.read!(version_file) |
Contributor
There was a problem hiding this comment.
Can it be compiled into the function? I'd like to remove most of the runtime behaviour from this library (wanted to discuss it with @ukutaht on the next call) ... Gettext-style, kind of. Probably doesn't matter since it wouldn't change the public API.
Contributor
|
This PR would probably need to add tests for the new |
ruslandoga
approved these changes
Jul 11, 2024
This is useful for users to know when the data has changed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the main repo we'll be starting to sync locations into ClickHouse. For that to work, we need two new features:
versionof the libraryRelated PR: plausible/analytics#4328