Test under JDK 26-ea#296
Conversation
📝 WalkthroughWalkthroughTwo GitHub Actions workflow files are updated to expand their Gradle CI build matrices. The Java version matrix in Possibly related PRs
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 60 minutes.Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/gradle-native-compile.yml:
- Around line 10-12: The workflow's strategy.matrix currently lists java
versions but lacks fail-fast configuration; update the strategy to include
fail-fast: false (i.e., set strategy.fail-fast to false alongside the existing
matrix/java values) so the 26-ea job failure won't cancel the 21 and 25
jobs—modify the strategy block that contains "matrix" and "java:
['21','25','26-ea']" to add the fail-fast setting, mirroring the existing
gradle.yml behavior.
In @.github/workflows/gradle.yml:
- Around line 10-12: Add fail-fast: false under the workflow's strategy matrix
to prevent an early-access (26-ea) failure from cancelling stable-version jobs;
locate the strategy -> matrix block (the matrix: java: ['21','25','26-ea']
entry) and add fail-fast: false at the same strategy level so all job variants
run to completion regardless of EA failures.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 50977e64-b4cd-4baa-9ede-9963cc916320
📒 Files selected for processing (2)
.github/workflows/gradle-native-compile.yml.github/workflows/gradle.yml
| strategy: | ||
| matrix: | ||
| java: ['21', '25'] | ||
| java: ['21', '25', '26-ea'] |
There was a problem hiding this comment.
🧹 Nitpick | 🔵 Trivial | ⚡ Quick win
Add fail-fast: false here too, same as gradle.yml.
The same concern applies: a 26-ea native-compilation failure (EA builds can break on native-image more readily than JIT) will cancel the 21 and 25 jobs mid-run, silencing the stable-version signal.
The setup-graalvm action already tests against GraalVM 25 and 26 EA builds in its own CI, confirming that java-version: '26-ea' is a valid input for graalvm/setup-graalvm@v1.
⚙️ Proposed fix
strategy:
+ fail-fast: false
matrix:
java: ['21', '25', '26-ea']📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| strategy: | |
| matrix: | |
| java: ['21', '25'] | |
| java: ['21', '25', '26-ea'] | |
| strategy: | |
| fail-fast: false | |
| matrix: | |
| java: ['21', '25', '26-ea'] |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.github/workflows/gradle-native-compile.yml around lines 10 - 12, The
workflow's strategy.matrix currently lists java versions but lacks fail-fast
configuration; update the strategy to include fail-fast: false (i.e., set
strategy.fail-fast to false alongside the existing matrix/java values) so the
26-ea job failure won't cancel the 21 and 25 jobs—modify the strategy block that
contains "matrix" and "java: ['21','25','26-ea']" to add the fail-fast setting,
mirroring the existing gradle.yml behavior.
| strategy: | ||
| matrix: | ||
| java: ['21', '25'] | ||
| java: ['21', '25', '26-ea'] |
There was a problem hiding this comment.
🧹 Nitpick | 🔵 Trivial | ⚡ Quick win
Add fail-fast: false to prevent EA failures from cancelling stable version jobs.
GitHub Actions defaults fail-fast to true. With 26-ea in the matrix, an EA-related failure would cancel any still-running 21 or 25 jobs, erasing the CI signal you actually need to protect. Setting fail-fast: false ensures all three variants run to completion regardless of whether the EA job fails.
actions/setup-java with distribution: 'temurin' does support early-access versions, so the 26-ea entry itself is valid.
⚙️ Proposed fix
strategy:
+ fail-fast: false
matrix:
java: ['21', '25', '26-ea']📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| strategy: | |
| matrix: | |
| java: ['21', '25'] | |
| java: ['21', '25', '26-ea'] | |
| strategy: | |
| fail-fast: false | |
| matrix: | |
| java: ['21', '25', '26-ea'] |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.github/workflows/gradle.yml around lines 10 - 12, Add fail-fast: false
under the workflow's strategy matrix to prevent an early-access (26-ea) failure
from cancelling stable-version jobs; locate the strategy -> matrix block (the
matrix: java: ['21','25','26-ea'] entry) and add fail-fast: false at the same
strategy level so all job variants run to completion regardless of EA failures.
1 participant
No description provided.