Skip to content

Test under JDK 26-ea #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mernst wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Test under JDK 26-ea #296

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e358fa
Test under JDK 26-ea
mernst Mar 29, 2026
ab6ebc7
Merge ../merging into java-26-ea
mernst May 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/gradle-native-compile.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:

strategy:
matrix:
java: ['21', '25']
java: ['21', '25', '26-ea']
Comment on lines 10 to +12
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot May 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick | 🔵 Trivial | ⚡ Quick win

Add fail-fast: false here too, same as gradle.yml.

The same concern applies: a 26-ea native-compilation failure (EA builds can break on native-image more readily than JIT) will cancel the 21 and 25 jobs mid-run, silencing the stable-version signal.

The setup-graalvm action already tests against GraalVM 25 and 26 EA builds in its own CI, confirming that java-version: '26-ea' is a valid input for graalvm/setup-graalvm@v1.

⚙️ Proposed fix 
     strategy:
+      fail-fast: false
       matrix:
         java: ['21', '25', '26-ea']
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
strategy:
matrix:
java: ['21', '25']
java: ['21', '25', '26-ea']
strategy:
fail-fast: false
matrix:
java: ['21', '25', '26-ea']
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/gradle-native-compile.yml around lines 10 - 12, The
workflow's strategy.matrix currently lists java versions but lacks fail-fast
configuration; update the strategy to include fail-fast: false (i.e., set
strategy.fail-fast to false alongside the existing matrix/java values) so the
26-ea job failure won't cancel the 21 and 25 jobs—modify the strategy block that
contains "matrix" and "java: ['21','25','26-ea']" to add the fail-fast setting,
mirroring the existing gradle.yml behavior.


steps:

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/gradle.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:

strategy:
matrix:
java: ['21', '25']
java: ['21', '25', '26-ea']
Comment on lines 10 to +12
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot May 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick | 🔵 Trivial | ⚡ Quick win

Add fail-fast: false to prevent EA failures from cancelling stable version jobs.

GitHub Actions defaults fail-fast to true. With 26-ea in the matrix, an EA-related failure would cancel any still-running 21 or 25 jobs, erasing the CI signal you actually need to protect. Setting fail-fast: false ensures all three variants run to completion regardless of whether the EA job fails.

actions/setup-java with distribution: 'temurin' does support early-access versions, so the 26-ea entry itself is valid.

⚙️ Proposed fix 
     strategy:
+      fail-fast: false
       matrix:
         java: ['21', '25', '26-ea']
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
strategy:
matrix:
java: ['21', '25']
java: ['21', '25', '26-ea']
strategy:
fail-fast: false
matrix:
java: ['21', '25', '26-ea']
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/gradle.yml around lines 10 - 12, Add fail-fast: false
under the workflow's strategy matrix to prevent an early-access (26-ea) failure
from cancelling stable-version jobs; locate the strategy -> matrix block (the
matrix: java: ['21','25','26-ea'] entry) and add fail-fast: false at the same
strategy level so all job variants run to completion regardless of EA failures.


steps:
- uses: actions/checkout@v6
Expand Down
Loading