Add space so Windows can process map - #130
Draft
eemperor wants to merge 1 commit into
Draft
Conversation
lorengordon
reviewed
Jul 29, 2026
| TF_VAR_common_args: ${{ inputs.watchmaker-common-args }} | ||
| TF_VAR_user_formulas: >- | ||
| {"${{ github.event.repository.name }}":"${{ inputs.formula-archive-url || format('https://github.com/{0}/archive/refs/heads/{1}.zip', github.event.pull_request.head.repo.full_name || github.repository, github.event.pull_request.head.ref || github.ref_name) }}"} | ||
| {"${{ github.event.repository.name }}": "${{ inputs.formula-archive-url || format('https://github.com/{0}/archive/refs/heads/{1}.zip', github.event.pull_request.head.repo.full_name || github.repository, github.event.pull_request.head.ref || github.ref_name) }}"} |
Member
There was a problem hiding this comment.
It should be valid json with or without the space. Fwiw, I left it out because it was easier to send the whole string through the various shells. To support spaces, the quoting required is a little heavier.
I suspect the error around the space is actually on the terrafirm side. The parser is "optimistic" in the sense that I didn't test support for parsing the user_formulas input on any windows systems...
https://github.com/plus3it/terrafirm/blob/master/templates/win_userdata.ps1#L21-L22
Member
Author
There was a problem hiding this comment.
Okay. Yeah, I also was looking at the windows template in terrafirm. Windows is doing something to the quoting/spacing that Watchmaker does not like.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.