Skip to content

Add space so Windows can process map #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
eemperor wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add space so Windows can process map #130

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test-terrafirm-integration.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ jobs:
TF_VAR_codebuild_id: ${{ github.run_id }}-${{ github.run_attempt }}
TF_VAR_common_args: ${{ inputs.watchmaker-common-args }}
TF_VAR_user_formulas: >-
{"${{ github.event.repository.name }}":"${{ inputs.formula-archive-url || format('https://github.com/{0}/archive/refs/heads/{1}.zip', github.event.pull_request.head.repo.full_name || github.repository, github.event.pull_request.head.ref || github.ref_name) }}"}
{"${{ github.event.repository.name }}": "${{ inputs.formula-archive-url || format('https://github.com/{0}/archive/refs/heads/{1}.zip', github.event.pull_request.head.repo.full_name || github.repository, github.event.pull_request.head.ref || github.ref_name) }}"}

@lorengordon lorengordon Jul 29, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be valid json with or without the space. Fwiw, I left it out because it was easier to send the whole string through the various shells. To support spaces, the quoting required is a little heavier.

I suspect the error around the space is actually on the terrafirm side. The parser is "optimistic" in the sense that I didn't test support for parsing the user_formulas input on any windows systems...

https://github.com/plus3it/terrafirm/blob/master/templates/win_userdata.ps1#L21-L22

@eemperor eemperor Jul 29, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. Yeah, I also was looking at the windows template in terrafirm. Windows is doing something to the quoting/spacing that Watchmaker does not like.

TF_VAR_git_ref: ${{ inputs.watchmaker-git-ref || 'main' }}
TF_VAR_git_repo: ${{ inputs.watchmaker-git-url || 'https://github.com/plus3it/watchmaker.git' }}
TF_VAR_source_builds: '["${{ inputs.source-build }}"]'
Expand Down