Closed
Conversation
17 tasks
polymorpher
reviewed
Aug 25, 2022
polymorpher
reviewed
Aug 25, 2022
polymorpher
reviewed
Aug 25, 2022
polymorpher
reviewed
Aug 25, 2022
| const ethers = require('ethers') | ||
| const DEBUG = process.env.MINISERVER_DEBUG === 'true' || process.env.MINISERVER_DEBUG === '1' | ||
| const APIDOCS = process.env.APIDOCS === 'true' || process.env.APIDOCS === '1' | ||
| const config = { |
Owner
There was a problem hiding this comment.
Let's clean this up to bare minimum
Collaborator
Author
There was a problem hiding this comment.
Have updated @polymorpher can you review again and see what else (if anything) should be removed 🙏
polymorpher
reviewed
Aug 25, 2022
polymorpher
reviewed
Aug 25, 2022
polymorpher
reviewed
Aug 25, 2022
polymorpher
reviewed
Aug 25, 2022
polymorpher
reviewed
Aug 25, 2022
polymorpher
reviewed
Aug 25, 2022
polymorpher
reviewed
Aug 25, 2022
polymorpher
reviewed
Aug 25, 2022
polymorpher
reviewed
Aug 25, 2022
polymorpher
reviewed
Aug 25, 2022
polymorpher
reviewed
Aug 25, 2022
polymorpher
reviewed
Aug 25, 2022
polymorpher
reviewed
Aug 25, 2022
polymorpher
reviewed
Aug 25, 2022
polymorpher
reviewed
Aug 25, 2022
polymorpher
reviewed
Aug 25, 2022
polymorpher
reviewed
Aug 25, 2022
polymorpher
reviewed
Aug 25, 2022
polymorpher
reviewed
Aug 25, 2022
polymorpher
reviewed
Aug 25, 2022
polymorpher
reviewed
Aug 25, 2022
polymorpher
reviewed
Aug 25, 2022
polymorpher
reviewed
Aug 25, 2022
polymorpher
requested changes
Aug 25, 2022
Owner
polymorpher
left a comment
polymorpher
left a comment
There was a problem hiding this comment.
Looks on the right track - we need to handle errors better, make code more consistent with common styles and good practice, and reduce code duplications
29 tasks
…eedback from PR 7
This was referenced Aug 30, 2022
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will include chain-code enhancements #3 and miniserver functionality #5