Miniwallet enhancements (including miniserver and smart contract changes)#8
Closed
johnwhitton wants to merge 10 commits intomainfrom
Closed
Miniwallet enhancements (including miniserver and smart contract changes)#8johnwhitton wants to merge 10 commits intomainfrom
johnwhitton wants to merge 10 commits intomainfrom
Conversation
…eedback from PR 7
17 tasks
This was referenced Sep 1, 2022
polymorpher
reviewed
Sep 2, 2022
polymorpher
reviewed
Sep 2, 2022
polymorpher
reviewed
Sep 2, 2022
polymorpher
reviewed
Sep 2, 2022
polymorpher
reviewed
Sep 2, 2022
polymorpher
reviewed
Sep 2, 2022
polymorpher
reviewed
Sep 2, 2022
polymorpher
reviewed
Sep 2, 2022
| signers[i] = signer.connect(provider) | ||
| } | ||
| } else { | ||
| signers[0] = new ethers.Wallet(networkConfig.key, networkConfig.provider) |
Owner
There was a problem hiding this comment.
signers has length 0 by default
Collaborator
Author
There was a problem hiding this comment.
Not sure what the ask here is
My thought is we need to set signers[0] when using a privateKey.
@polymorpher can you clarify 🙏
polymorpher
reviewed
Sep 2, 2022
polymorpher
reviewed
Sep 2, 2022
polymorpher
reviewed
Sep 2, 2022
polymorpher
reviewed
Sep 2, 2022
polymorpher
reviewed
Sep 2, 2022
polymorpher
reviewed
Sep 2, 2022
polymorpher
reviewed
Sep 2, 2022
polymorpher
reviewed
Sep 2, 2022
polymorpher
reviewed
Sep 2, 2022
polymorpher
reviewed
Sep 2, 2022
polymorpher
requested changes
Sep 2, 2022
Owner
polymorpher
left a comment
polymorpher
left a comment
There was a problem hiding this comment.
Overall looks good. Just need some minor simplifications
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses issues
It is forked from PR #7 Initial version of miniwallet server
It incorporates all the changes in #7 and as such #7 can be closed and work can be progressed under this PR.
Alternatively we can merge #7 first and then this PR.
Enabling the miniserver enhancements to be merged independently from the Smart Contract enhancements.