Skip to content

added a compile button to footer#25

Open
escher-m wants to merge 2 commits intopoush:masterfrom
escher-m:patch-2
Open

added a compile button to footer#25
escher-m wants to merge 2 commits intopoush:masterfrom
escher-m:patch-2

Conversation

@escher-m
Copy link
Copy Markdown

@escher-m escher-m commented Apr 29, 2020

for issue #1 (adding spinner during compiling) and issue #21

-Team BigUhOh (RGSoC '20)

@poush poush requested review from Anonymous26 and shashaBot April 30, 2020 09:14
@shashaBot
Copy link
Copy Markdown
Collaborator

@escher-m could you add the onclick listener on the compile button to execute the compile function. Thanks!

Copy link
Copy Markdown
Collaborator

@shashaBot shashaBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These change�s do not address issue #1 as mentioned by you. Please make sure you have included those changes in the PR.

Comment thread index.html Outdated
<!-- <li type="button" id="fullscreen"> <i class="fa fa-expand"></i> Go full screen </li> -->
<li type="button" id="togetherjs"> <i class="fa fa-share"></i> Start Collaboration mode </li>
<li type="button" id="logout"> <i class="fa fa-sign-out"></i> Logout </li>
<li type="button" id="compile"> <i class="fa fa-compile"></i> Compile Code </li>
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no fa-compile css class present in font awesome. Please use a relevant icon from icon library or include an svg icon here.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made changes

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

used fa-spinner instead

@escher-m
Copy link
Copy Markdown
Author

escher-m commented May 9, 2020

I've called the compile function (in the utils.js file) using onclick. But on running it in the localhost, compilation is happening properly on using cmd+S but on using the compile button error- "Fatal error occurred, no output PDF file produced!" is shown during compiling.

What would you suggest I look into to fix this? @shashaBot @poush

@escher-m
Copy link
Copy Markdown
Author

escher-m commented May 9, 2020

These change�s do not address issue #1 as mentioned by you. Please make sure you have included those changes in the PR.

Working on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants