Format: Don't allow tabs#1573
Merged
hanno-becker merged 4 commits intomainfrom Mar 13, 2026
Merged
Conversation
Contributor
mkannwischer
commented
Feb 20, 2026
- Resolves format: Don't allow tabs #1520
Contributor
CBMC Results (ML-KEM-512)Full Results (186 proofs)
|
Contributor
CBMC Results (ML-KEM-768)Full Results (186 proofs)
|
Contributor
CBMC Results (ML-KEM-1024)Full Results (186 proofs)
|
hanno-becker
approved these changes
Feb 25, 2026
Contributor
Author
Contributor
objdump uses tabs between mnemonics and operands. Expand them to spaces so that auto-generated assembly files are tab-free. Signed-off-by: Matthias J. Kannwischer <matthias@kannwischer.eu>
Add an expand-tabs step to scripts/format and a tab-check to scripts/lint. Makefiles, patches, and assembly (.S) are excluded. Signed-off-by: Matthias J. Kannwischer <matthias@kannwischer.eu>
Signed-off-by: Matthias J. Kannwischer <matthias@kannwischer.eu>
Add missing .PHONY targets found via checkmake. checkmake is not added to the lint pipeline due to many false positives. Signed-off-by: Matthias J. Kannwischer <matthias@kannwischer.eu>
Contributor
hanno-becker
left a comment
There was a problem hiding this comment.
Should we also set UseTab: Never in .clang-format to prevent formatting-introduced tabs?
Contributor
Author
Isn't that already the case when you do |
Contributor
|
@mkannwischer Good point, you are right. |
hanno-becker
approved these changes
Mar 13, 2026
mkannwischer
added a commit
to pq-code-package/mldsa-native
that referenced
this pull request
Apr 6, 2026
This commit ports pq-code-package/mlkem-native#1573. It replaces tabs by spaces in - All autogenerated asm via simpasm - All handwritten asm - All c/h source files It also extends the format and lint script to enforce the absense of tabs in source files. Signed-off-by: Matthias J. Kannwischer <matthias@zerorisc.com>
mkannwischer
added a commit
to pq-code-package/mldsa-native
that referenced
this pull request
Apr 22, 2026
This commit ports pq-code-package/mlkem-native#1573. It replaces tabs by spaces in - All autogenerated asm via simpasm - All handwritten asm - All c/h source files It also extends the format and lint script to enforce the absense of tabs in source files. Signed-off-by: Matthias J. Kannwischer <matthias@zerorisc.com>
mkannwischer
added a commit
to pq-code-package/mldsa-native
that referenced
this pull request
Apr 22, 2026
This commit ports pq-code-package/mlkem-native#1573. It replaces tabs by spaces in - All autogenerated asm via simpasm - All handwritten asm - All c/h source files It also extends the format and lint script to enforce the absense of tabs in source files. Signed-off-by: Matthias J. Kannwischer <matthias@zerorisc.com>
mkannwischer
added a commit
to pq-code-package/mldsa-native
that referenced
this pull request
Apr 22, 2026
This commit ports pq-code-package/mlkem-native#1573. It replaces tabs by spaces in - All autogenerated asm via simpasm - All handwritten asm - All c/h source files It also extends the format and lint script to enforce the absense of tabs in source files. Signed-off-by: Matthias J. Kannwischer <matthias@zerorisc.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.