Reklamup Bid Adapter: add new adapter#14550
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7b8f4bffea
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
Hey everyone! 👋 Hope you're all doing great! Just dropping by to say hi and to let you know we're around if there are any questions about our Reklamup Bid Adapter PR. |
|
Whoa there partner! This project is migrating to typescript. Consider changing the new JS files to TS, with well-defined types for what interacts with the prebid public API (for example: bid params and configuration). Thanks!
|
patmmccann
left a comment
patmmccann
left a comment
There was a problem hiding this comment.
needs a tweak with the rebase
|
Hi @patmmccann, rebased and migrated the adapter to TypeScript. Please take a look when you get a chance. Thanks! |
|
Thanks so much! nice |
Coverage Report for CI Build 24196924485Warning Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes. Coverage remained the same at 96.343%Details
Uncovered Changes
Coverage Regressions2 previously-covered lines in 1 file lost coverage.
Coverage Stats
💛 - Coveralls |
* Reklamup Bid Adapter: add new adapter * Reklamup Bid Adapter: migrate adapter to TypeScript --------- Co-authored-by: Reklamup <support@reklamup.com>
3 participants
Type of change
Bugfix
Feature
New bidder adapter
Updated bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Other information
Documentation PR: prebid/prebid.github.io#6460