Livewrapped Analytics Adapter: Clear Livewrapped analytics cache when pbjs.clearAllAuctions is called#14868
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7cb793f22b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| prebidGlobal.clearAllAuctions = function() { | ||
| cache.auctions = {}; | ||
| baseClearAllAuctions(); |
There was a problem hiding this comment.
This change makes cache.auctions cleanup depend entirely on pbjs.clearAllAuctions(), but that API is optional and typically not called in normal auction flows. After removing the timed cleanup in sendEvents, every completed auction remains in memory indefinitely, so sendEvents keeps iterating an ever-growing cache on subsequent auctions and can degrade long-lived pages (memory and CPU) even when no new data from old auctions is sent.
Useful? React with 👍 / 👎.
|
@patmmccann so it's not possible to submit PRs to legacy branches? |
2 participants
Type of change
Description of change
A change was applied (#13639) that broke the Livewrapped Analytics adapter. This will fix the issue and hopefully not trigger the robot again.
Other information
#13639
#14870