Livewrapped Analytics Adapter: Clear Livewrapped analytics cache when pbjs.clearAllAuctions is called#14870
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e91c73db0d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:
Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀 |
patmmccann
left a comment
There was a problem hiding this comment.
did you somehow disable tests from running? we cannot merge without them
if you do not like what codex says, simply address its comments in a response. It is there to give helpful suggestions, not to prevent merge.
I'm not sure how I could have done that by submitting a PR consisting of only two files with rather small changes? |
|
Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:
Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀 |
Type of change
Description of change
A change was applied (#13639) that broke the Livewrapped Analytics adapter. This will fix the issue and hopefully not trigger the robot again.
Other information
#13639
#14868