Upgrading Go version from 1.24 to 1.26#4737
Open
karwaankit32 wants to merge 10 commits into
Open
Conversation
Code coverage summaryNote:
adapterstestRefer here for heat map coverage report |
Code coverage summaryNote:
adapterstestRefer here for heat map coverage report |
Contributor
|
Curious, entire json and yaml files are showing up as a change. Did you inadvertently change the line endings? |
SyntaxNode
reviewed
Apr 1, 2026
| mockMetricEngine := &metrics.MetricsEngineMock{} | ||
| expectedAdapterName := openrtb_ext.BidderAppnexus | ||
| compareConnWaitTime := func(dur time.Duration) bool { return dur.Nanoseconds() > 0 } | ||
| compareConnWaitTime := func(dur time.Duration) bool { return dur >= 0 } |
Contributor
There was a problem hiding this comment.
Why is this change needed?
| module github.com/prebid/prebid-server/v4 | ||
|
|
||
| go 1.23.0 | ||
| go 1.24 |
Contributor
There was a problem hiding this comment.
We support the latest two releases, so the minimum version here should be 1.25.
| ## Developing | ||
|
|
||
| Prebid Server requires [Go](https://go.dev) version 1.23 or newer. You can develop on any operating system that Go supports; however, please note that our helper scripts are written in bash. | ||
| Prebid Server requires [Go](https://go.dev) version 1.24 or newer. You can develop on any operating system that Go supports; however, please note that our helper scripts are written in bash. |
Contributor
Author
There was a problem hiding this comment.
Using 1.25 starts making the webhooks fail. Also, current version being used is 1.24, shouldn't we be setting it to that?
Contributor
There was a problem hiding this comment.
Using 1.25 starts making the webhooks fail.
What do you mean?
current version being used is 1.24
This PR is upgrading the current version to 1.26. Since we support current and current-1, we use current-1 version here for the tool chain to ensure compatability.
Contributor
There was a problem hiding this comment.
Go version 1.26.2 is fully stable. One reason to upgrade to the latest version https://go.dev/doc/go1.25 it includes changes related to cgroups, which are necessary for those running PBS in Kubernetes
Contributor
|
The go version should be at least 1.26.2. Previous versions 1.26.x have bugs in delve debugger |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrading Go version build from 1.24 and 1.26.
Doing version compatibility fixes
Testing
Ran all Unit tests
Tested following endpoints -