Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"dockerfile": "Dockerfile",
"args": {
// Update the VARIANT arg to pick a version of Go
"VARIANT": "1.24",
"VARIANT": "1.26",
// Options
"INSTALL_NODE": "false",
"NODE_VERSION": "lts/*"
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/adapter-code-coverage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
- name: Install Go
uses: actions/setup-go@v5
with:
go-version: 1.24.0
go-version: 1.26.2

- name: Checkout Code
uses: actions/checkout@v4
Expand Down Expand Up @@ -46,6 +46,8 @@ jobs:
- name: Run Coverage Tests
id: run_coverage
if: steps.get_directories.outputs.result != ''
env:
GOTOOLCHAIN: local
run: |
directories=$(echo '${{ steps.get_directories.outputs.result }}' | jq -r '.[]')
go mod download
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/validate-merge.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
- name: Install Go
uses: actions/setup-go@v5
with:
go-version: 1.24.0
go-version: 1.26.2

- name: Checkout Merged Branch
uses: actions/checkout@v4
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/validate.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
validate:
strategy:
matrix:
go-version: [1.23.x, 1.24.x]
go-version: [1.25.x, 1.26.x]
os: [ubuntu-latest]
runs-on: ${{ matrix.os }}

Expand All @@ -31,3 +31,4 @@ jobs:
./validate.sh --nofmt --cov --race 10
env:
GO111MODULE: "on"
GOTOOLCHAIN: local
4 changes: 2 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ RUN apt-get update && \
apt-get -y upgrade && \
apt-get install -y --no-install-recommends wget ca-certificates
WORKDIR /tmp
RUN wget https://dl.google.com/go/go1.24.0.linux-amd64.tar.gz && \
tar -xf go1.24.0.linux-amd64.tar.gz && \
RUN wget https://dl.google.com/go/go1.26.2.linux-amd64.tar.gz && \
tar -xf go1.26.2.linux-amd64.tar.gz && \
mv go /usr/local
RUN mkdir -p /app/prebid-server/
WORKDIR /app/prebid-server/
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ Ensure that you deploy the `/static` directory, as Prebid Server requires those

## Developing

Prebid Server requires [Go](https://go.dev) version 1.23 or newer. You can develop on any operating system that Go supports; however, please note that our helper scripts are written in bash.
Prebid Server requires [Go](https://go.dev) version 1.26.2 or newer. You can develop on any operating system that Go supports; however, please note that our helper scripts are written in bash.

1. Clone The Repository
``` bash
Expand Down
6 changes: 3 additions & 3 deletions adapters/adapterstest/adapter_test_util.go
Original file line number Diff line number Diff line change
Expand Up @@ -45,21 +45,21 @@ func SampleBid(width *int64, height *int64, impId string, index int) openrtb2.Bi
// VerifyStringValue Helper function to assert string equals.
func VerifyStringValue(value string, expected string, t *testing.T) {
if value != expected {
t.Fatalf(fmt.Sprintf("%s expected, got %s", expected, value))
t.Fatalf("%s expected, got %s", expected, value)
Comment thread
SyntaxNode marked this conversation as resolved.
}
}

// VerifyIntValue Helper function to assert Int equals.
func VerifyIntValue(value int, expected int, t *testing.T) {
if value != expected {
t.Fatalf(fmt.Sprintf("%d expected, got %d", expected, value))
t.Fatalf("%d expected, got %d", expected, value)
}
}

// VerifyBoolValue Helper function to assert bool equals.
func VerifyBoolValue(value bool, expected bool, t *testing.T) {
if value != expected {
t.Fatalf(fmt.Sprintf("%v expected, got %v", expected, value))
t.Fatalf("%v expected, got %v", expected, value)
}
}

Expand Down
2 changes: 1 addition & 1 deletion endpoints/openrtb2/amp_auction_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -2491,7 +2491,7 @@ func TestAmpAuctionDebugWarningsOnly(t *testing.T) {
)

for _, test := range testCases {
httpReq := httptest.NewRequest("GET", fmt.Sprintf("/openrtb2/auction/amp"+test.requestURLArguments), nil)
httpReq := httptest.NewRequest("GET", "/openrtb2/auction/amp"+test.requestURLArguments, nil)
Comment thread
SyntaxNode marked this conversation as resolved.
test.addRequestHeaders(httpReq)
recorder := httptest.NewRecorder()

Expand Down
3 changes: 1 addition & 2 deletions exchange/bidder.go
Original file line number Diff line number Diff line change
Expand Up @@ -616,7 +616,7 @@ func (bidder *BidderAdapter) doRequestImpl(ctx context.Context, req *adapters.Re
httpResp, err := ctxhttp.Do(ctx, bidder.Client, httpReq)
if err != nil {
bidder.logHealthCheck(false)
if err == context.DeadlineExceeded {
if errors.Is(err, context.DeadlineExceeded) {
err = &errortypes.Timeout{Message: err.Error()}
var corebidder adapters.Bidder = bidder.Bidder
// The bidder adapter normally stores an info-aware bidder (a bidder wrapper)
Expand All @@ -631,7 +631,6 @@ func (bidder *BidderAdapter) doRequestImpl(ctx context.Context, req *adapters.Re
// a loop of trying to report timeouts to the timeout notifications.
go bidder.doTimeoutNotification(tb, req, logger)
}

}
return &httpCallInfo{
request: req,
Expand Down
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/prebid/prebid-server/v4

go 1.23.0
go 1.25

require (
github.com/51Degrees/device-detection-go/v4 v4.4.35
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
package devicedetection

import (
"fmt"
"math"

"github.com/prebid/prebid-server/v4/hooks/hookexecution"
Expand Down Expand Up @@ -37,7 +36,7 @@ func handleAuctionRequestHook(ctx hookstage.ModuleInvocationContext, deviceDetec

result, err := hydrateFields(deviceInfo, rawPayload)
if err != nil {
return rawPayload, hookexecution.NewFailure(fmt.Sprintf("error hydrating fields %s", err))
return rawPayload, hookexecution.NewFailure("error hydrating fields %s", err)
Comment thread
SyntaxNode marked this conversation as resolved.
}

return result, nil
Expand Down
Loading