Auto-link / Close Issues for 2.0 PRs (p5.js & p5.js-website)#919
Merged
ksen0 merged 12 commits intoprocessing:2.0from Sep 15, 2025
Merged
Auto-link / Close Issues for 2.0 PRs (p5.js & p5.js-website)#919ksen0 merged 12 commits intoprocessing:2.0from
ksen0 merged 12 commits intoprocessing:2.0from
Conversation
17 tasks
lirenjie95
suggested changes
Jul 27, 2025
Contributor
lirenjie95
left a comment
lirenjie95
left a comment
There was a problem hiding this comment.
Hi @NalinDalal , I think this PR should belong to the https://github.com/processing/p5.js repo. Can you please close this one and open another one there?
Contributor
Author
|
thanks for comment, but since you pointed this out, I am pretty sure original issue ask for feature in both repo, however if not planned for this one, do let know @lirenjie95 |
Contributor
Author
|
corresponding pr: processing/p5.js#7989 |
3 tasks
Member
|
Relates to processing/p5.js#7975 |
NalinDalal
changed the title
ksen0
reviewed
Sep 1, 2025
Member
ksen0
left a comment
ksen0
left a comment
There was a problem hiding this comment.
Thanks for all your work on this! See also my comment in processing/p5.js#8025
| - name: Close linked issues on non-default branches | ||
| uses: processing/branch-pr-close-issue@v1 | ||
| with: | ||
| token: ${{ secrets.GITHUB_TOKEN }} |
Member
There was a problem hiding this comment.
Please add the branch: 2.0 here, as this action expects this
Contributor
Author
|
is it correct now @ksen0 |
Member
|
Thanks for the reminder @NalinDalal ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
created yaml file for GitHub Action to close linked issues on PR merge to 2.0