Merged
Conversation
Merged
DeeDeeG
approved these changes
Feb 18, 2026
Member
DeeDeeG
left a comment
DeeDeeG
left a comment
There was a problem hiding this comment.
Just dependency bumps, and CI passes. Pretty easy approve for me!
Surprising that rimraf isn't even used...!
Member
Author
|
Thanks for the review @DeeDeeG ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I know I've been pretty active on this repo the past little bit, but this is really the actual reason why. Over in
pulsar-edit/pulsar#1404I detailed how duplicated dependencies take up a pretty hefty chunk of space in our binary. With one of those being theasyncpackage. This repository contains one of the many duplicate, different versions of that dependency, so finally we can get it updated here.But before I could do that, or while I was, I had to decaf and cleanup the repo. And while I was here doing this, thought it'd be best to go ahead and also update all the other deps that are in this repo, and afterwards we can get it prepped for NPM publishing.
All that to say, this PR is focused solely on bumping the dependencies here.