chore(deps): bump approx-chol 0.4.0 -> 0.5.0 - #253
Merged
Conversation
The dependency dropped `original_n` from the serialized `Factor` and bumped its own FACTOR_FORMAT_VERSION, so within's `Preconditioner` wire format shifts v12 -> v13 transitively. Fixture regenerated; v12 becomes the pre-bump negative.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps
approx-chol0.4.0 → 0.5.0. No API changes at within's call sites; MSRV stays 1.85.Breaking: the serialized
Preconditionerwire format shifts v12 → v13. approx-chol droppedoriginal_nfrom its serializedFactorand bumped its ownFACTOR_FORMAT_VERSION, so 0.3.0bytes no longer decode. Fixture regenerated; v12 becomes the pre-bump negative.
The sampler is faster and the sampled Schur is unchanged. Standalone A/B with both versions
linked into one binary, interleaved arms, 0.4.0 re-run as a null control, n=25:
Fill-edge checksums identical in all three. 0.5.0 also replaced the uniform-draw mapping with a
53-bit one that cannot return 1.0; it moves a draw by at most 2^-53, too little to change a CDF
bucket (zero divergences in 1.7M draws), so the preconditioner is bitwise unchanged.