Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ and this project follows [Semantic Versioning](https://semver.org/).

## [Unreleased]

### Changed

- **BREAKING:** The serialized `Preconditioner` wire format changed (v12 → v13) with the `approx-chol` 0.4 → 0.5 bump; 0.3.0 bytes no longer decode.

### Fixed

- A design carrying varying slopes on two distinct factors could fail preconditioner construction with `matrix is not symmetric`, when rounding left the two triangles of the exact Schur complement unequal (#229).
Expand Down
4 changes: 2 additions & 2 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion crates/within/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ categories.workspace = true

[dependencies]
schwarz-precond = { workspace = true, features = ["serde"] }
approx-chol = { version = "0.4.0", features = ["serde"] }
approx-chol = { version = "0.5.0", features = ["serde"] }
serde = { workspace = true, features = ["rc"] }
postcard.workspace = true
ndarray = "0.17"
Expand Down
Binary file not shown.
Binary file not shown.
10 changes: 5 additions & 5 deletions crates/within/tests/wire_format_fixture.rs
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@

use within::{Effect, LsmrOptions, Preconditioner, PreconditionerConfig, Solver};

const WIRE_FORMAT_VERSION: u32 = 12;
const PRECOND_BYTES: &[u8] = include_bytes!("fixtures/preconditioner_v12.postcard");
const PRE_BUMP_BYTES: &[u8] = include_bytes!("fixtures/preconditioner_v11.postcard");
const WIRE_FORMAT_VERSION: u32 = 13;
const PRECOND_BYTES: &[u8] = include_bytes!("fixtures/preconditioner_v13.postcard");
const PRE_BUMP_BYTES: &[u8] = include_bytes!("fixtures/preconditioner_v12.postcard");

fn fixture_problem() -> (Vec<u32>, Vec<u32>, Vec<f64>, Vec<f64>) {
// The frustrated (f-slope, g) pair pins a signed operator with Scaled coords and a Cover.
Expand Down Expand Up @@ -96,7 +96,7 @@ fn pre_bump_fixture_no_longer_decodes() {
}

/// Generate the wire-format fixture. Run with `--ignored` to overwrite
/// `crates/within/tests/fixtures/preconditioner_v12.postcard`. Intended for
/// `crates/within/tests/fixtures/preconditioner_v13.postcard`. Intended for
/// intentional wire-format bumps only; CI runs the non-ignored tests above.
#[test]
#[ignore]
Expand All @@ -117,7 +117,7 @@ fn regenerate_wire_format_fixture() {
let bytes = postcard::to_stdvec(prec).expect("serialize");

let mut path = PathBuf::from(env!("CARGO_MANIFEST_DIR"));
path.push("tests/fixtures/preconditioner_v12.postcard");
path.push("tests/fixtures/preconditioner_v13.postcard");
let mut out = std::fs::File::create(&path).expect("create fixture file");
out.write_all(&bytes).expect("write fixture bytes");
eprintln!("wrote {} bytes to {}", bytes.len(), path.display());
Expand Down
Loading