Use PyO3's declarative modules#249
Merged
seddonym merged 5 commits intopython-grimp:mainfrom Sep 8, 2025
Merged
Conversation
Implement the Python `clone` method as a wrapper around the derived `clone`.
LilyFirefly
force-pushed
the
declarative-module
branch
from
e003f69 to
e3765cb
Compare
CodSpeed Instrumentation Performance ReportMerging #249 will degrade performances by 15.63%Comparing Summary
Benchmarks breakdown
|
Merged
seddonym
approved these changes
Sep 8, 2025
Collaborator
seddonym
left a comment
seddonym
left a comment
There was a problem hiding this comment.
Great changes, thanks so much.
| m.add("ParseError", py.get_type::<ParseError>())?; | ||
| m.add("CorruptCache", py.get_type::<CorruptCache>())?; | ||
| Ok(()) | ||
| mod _rustgrimp { |
Collaborator
There was a problem hiding this comment.
Been meaning to do this for a while, thanks!
| .ok_or(GrimpError::ModuleNotPresent(name.to_owned())) | ||
| } | ||
|
|
||
| fn parse_containers( |
Collaborator
There was a problem hiding this comment.
Didn't realise there were two impl blocks! Thanks.
| /// | ||
| /// Returns dict[Module, set[DirectImport]]. | ||
| #[pyfunction] | ||
| pub fn scan_for_imports<'py>( |
Collaborator
There was a problem hiding this comment.
Good call. Originally the design was to have lib.rs as the Python layer but as you will have noticed, we are no longer sticking to that as the crate has grown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also refactor
GraphWrapperand movescan_for_importsinto theimport_scanningmodule.