Skip to content

add argument to allow download a range of versions of a package#45

Merged
ido50 merged 2 commits into
python-morgan:mainfrom
philnewm:override-version-filter
Oct 17, 2025
Merged

add argument to allow download a range of versions of a package#45
ido50 merged 2 commits into
python-morgan:mainfrom
philnewm:override-version-filter

Conversation

@philnewm
Copy link
Copy Markdown
Collaborator

@philnewm philnewm commented Sep 17, 2025

I would like to add an argument to allow the download of a range of versions of packages.

This approach works like a simple switch and keeps the default functionality untouched.

It's important to note that this changes the dependency resolution of multiple packages.

  • Previously, when multiple versions were defined of a single package, it pulled in the intersection of both sets of requirements/dependencies.
  • With this change, it will pull in the union of both sets of requirements/dependencies instead. This means, you can pull a large range of package versions and have the full dependency trees of each version.

@philnewm philnewm changed the title add argument to disbale version filter add argument to disable version filter Sep 17, 2025
@philnewm philnewm marked this pull request as draft September 18, 2025 15:35
@philnewm
Copy link
Copy Markdown
Collaborator Author

I noticed that the current changes also cause all versions of all dependencies to download.
Not sure if this makes much sense, will check how to adjust that.

Comment thread morgan/__init__.py Outdated
@philnewm philnewm force-pushed the override-version-filter branch from 7c5ded5 to 6405dab Compare September 22, 2025 15:58
@philnewm philnewm marked this pull request as ready for review September 22, 2025 16:01
@philnewm philnewm changed the title add argument to disable version filter add argument to allow download a range of versions of a package Sep 22, 2025
@philnewm
Copy link
Copy Markdown
Collaborator Author

Enhanced the "all-versions" logic and updated the PR description accordingly.

Comment thread morgan/__init__.py Outdated
Comment thread morgan/__init__.py Outdated
@philnewm philnewm marked this pull request as draft October 14, 2025 09:11
@philnewm philnewm force-pushed the override-version-filter branch from b6cdc35 to 1bdc9ab Compare October 14, 2025 11:08
@philnewm philnewm marked this pull request as ready for review October 14, 2025 11:09
@philnewm
Copy link
Copy Markdown
Collaborator Author

Rebase and fixed tests for new argument --mirror-all-versions

@grische grische force-pushed the override-version-filter branch from 1bdc9ab to 468b95c Compare October 14, 2025 11:28
Mirror all versions matching requirements in morgan.ini.
Mirror only required dependencies of each top-level package version.
@grische grische force-pushed the override-version-filter branch from 468b95c to 0ebba93 Compare October 14, 2025 14:32
@philnewm
Copy link
Copy Markdown
Collaborator Author

Updated tests for argument --mirror-all-versions

When pulling in multiple versions of the same package, the dependencies
could change and all dependencies of all versions need to be considered.
@philnewm philnewm force-pushed the override-version-filter branch from fbde2b2 to e1df825 Compare October 17, 2025 08:16
@ido50 ido50 merged commit 36fea43 into python-morgan:main Oct 17, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants