Skip more pyexpat tests based on compile-time expat version, not runtime - #155638
Open
hroncok wants to merge 1 commit into
Open
Skip more pyexpat tests based on compile-time expat version, not runtime#155638hroncok wants to merge 1 commit into
hroncok wants to merge 1 commit into
Conversation
This is a followup for pythonGH-144739 and pythonGH-155485
picnixz
reviewed
Aug 12, 2026
|
|
||
|
|
||
| class ReparseDeferralTest(unittest.TestCase): | ||
| deferal_supported = expat.ParserCreate().GetReparseDeferralEnabled() |
Member
There was a problem hiding this comment.
Please protect this call just in case (put it at the top-level of the file, see ssl tests for instance)
Contributor
Author
There was a problem hiding this comment.
I'll have a look. Not sure what you mean by protect, but hopefully that will be more obvious when I do.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a followup for GH-144739 and GH-155485