Skip to content

Skip more pyexpat tests based on compile-time expat version, not runtime #155638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hroncok wants to merge 2 commits into
base: main
Choose a base branch
from
+13 −8
Open

Skip more pyexpat tests based on compile-time expat version, not runtime #155638

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a69fda5
Skip more pyexpat tests based on compile-time expat version, not runtime
hroncok Aug 12, 2026
2261381
fixup! Skip more pyexpat tests based on compile-time expat version, n…
hroncok Aug 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions Lib/test/test_pyexpat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,11 @@
from xml.parsers.expat import errors


# pyexpat built with expat 2.6.0+ has support for reparse deferral
# and defaults to enabled
HAS_REPARSE_DEFERRAL = expat.ParserCreate().GetReparseDeferralEnabled()


class SetAttributeTest(unittest.TestCase):
def setUp(self):
self.parser = expat.ParserCreate(namespace_separator='!')
Expand Down Expand Up @@ -1097,7 +1102,7 @@ def test_error_path_no_crash(self):
class ReparseDeferralTest(unittest.TestCase):
def test_getter_setter_round_trip(self):
parser = expat.ParserCreate()
enabled = (expat.version_info >= (2, 6, 0))
enabled = HAS_REPARSE_DEFERRAL

self.assertIs(parser.GetReparseDeferralEnabled(), enabled)
parser.SetReparseDeferralEnabled(False)
Expand All @@ -1106,8 +1111,8 @@ def test_getter_setter_round_trip(self):
self.assertIs(parser.GetReparseDeferralEnabled(), enabled)

def test_reparse_deferral_enabled(self):
if expat.version_info < (2, 6, 0):
self.skipTest(f'Expat {expat.version_info} does not '
if not HAS_REPARSE_DEFERRAL:
self.skipTest(f'Expat < 2.6.0 does not '
'support reparse deferral')

started = []
Expand Down Expand Up @@ -1137,7 +1142,7 @@ def start_element(name, _):

parser = expat.ParserCreate()
parser.StartElementHandler = start_element
if expat.version_info >= (2, 6, 0):
if HAS_REPARSE_DEFERRAL:
parser.SetReparseDeferralEnabled(False)
self.assertFalse(parser.GetReparseDeferralEnabled())

Expand Down
4 changes: 2 additions & 2 deletions Lib/test/test_sax.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1216,8 +1216,8 @@ def test_expat_incremental_reset(self):

self.assertEqual(result.getvalue(), start + b"<doc>text</doc>")

@unittest.skipIf(pyexpat.version_info < (2, 6, 0),
f'Expat {pyexpat.version_info} does not '
@unittest.skipIf(not pyexpat.ParserCreate().GetReparseDeferralEnabled(),
'Python compiled with Expat < 2.6.0 does not '
'support reparse deferral')
def test_flush_reparse_deferral_enabled(self):
result = BytesIO()
Expand Down
4 changes: 2 additions & 2 deletions Lib/test/test_xml_etree.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1915,8 +1915,8 @@ def test_unknown_event(self):
with self.assertRaisesRegex(ValueError, "unknown event 'bogus'"):
ET.XMLPullParser(events=(x.decode() for x in (b'start', b'end', b'bogus')))

@unittest.skipIf(pyexpat.version_info < (2, 6, 0),
f'Expat {pyexpat.version_info} does not '
@unittest.skipIf(not pyexpat.ParserCreate().GetReparseDeferralEnabled(),
'Python compiled with Expat < 2.6.0 does not '
'support reparse deferral')
def test_flush_reparse_deferral_enabled(self):
parser = ET.XMLPullParser(events=('start', 'end'))
Expand Down
Loading