Conversation
stack-info: PR: #1847, branch: shunting314/stack/25
7adea7c to
5686af9
Compare
5686af9 to
fa8e33f
Compare
|
Could we use autotune_config_overrides for this? |
|
related discussion: #1415 |
I think they target different things.
While the custom config filter can ignore configs either because block-size is too small or we want to avoid using TMA for some reasons. The filter can cover all cases mentioned in #1415 btw |
|
Maybe we could extend the existing API? Another other ideas considered? |
I think a filter function is more flexible then an overriding dict. We can do more things with the filter function. E.g. with overriding function, we can not skip config with too small block size. One idea to consolidate the two APIs is, we let the filter function return |
fa8e33f to
aa95dba
Compare
aa95dba to
a42cffc
Compare
a42cffc to
704fec4
Compare
704fec4 to
98ab5e0
Compare
98ab5e0 to
b313874
Compare
b313874 to
4aec4fc
Compare
17fc723 to
5fb5b3a
Compare
jansel
left a comment
There was a problem hiding this comment.
Let's go with the Config | None path. Re-request review once this is updated.
stack-info: PR: #1847, branch: shunting314/stack/25
4aec4fc to
b201aae
Compare
|
Updated the API to allowing both filtering & overriding a config. Should we remove |
custom config filter
Motivations