rendezvous only once for matmul reduce scatter#1824
Merged
shunting314 merged 1 commit intomainfrom Mar 27, 2026
Merged
Conversation
shunting314
added a commit
that referenced
this pull request
Mar 26, 2026
stack-info: PR: #1824, branch: shunting314/stack/22
shunting314
force-pushed
the
shunting314/stack/22
branch
from
827159b to
0a4b037
Compare
This was referenced Mar 26, 2026
meta-cla
bot
added
the
CLA Signed
shunting314
force-pushed
the
shunting314/stack/22
branch
from
0a4b037 to
0692f5d
Compare
shunting314
added a commit
that referenced
this pull request
Mar 26, 2026
stack-info: PR: #1824, branch: shunting314/stack/22
shunting314
added a commit
that referenced
this pull request
Mar 26, 2026
stack-info: PR: #1824, branch: shunting314/stack/22
shunting314
force-pushed
the
shunting314/stack/22
branch
from
0692f5d to
45bb050
Compare
shunting314
added a commit
that referenced
this pull request
Mar 26, 2026
stack-info: PR: #1824, branch: shunting314/stack/22
shunting314
force-pushed
the
shunting314/stack/22
branch
from
45bb050 to
8b6d57d
Compare
shunting314
added a commit
that referenced
this pull request
Mar 26, 2026
stack-info: PR: #1824, branch: shunting314/stack/22
shunting314
force-pushed
the
shunting314/stack/22
branch
from
8b6d57d to
4a0e82b
Compare
shunting314
added a commit
that referenced
this pull request
Mar 26, 2026
stack-info: PR: #1824, branch: shunting314/stack/22
shunting314
force-pushed
the
shunting314/stack/22
branch
from
4a0e82b to
af5bbae
Compare
yf225
approved these changes
Mar 26, 2026
jansel
reviewed
Mar 27, 2026
|
|
||
|
|
||
| def helion_matmul_reduce_scatter( | ||
| symm_mem_buffer: torch.Tensor, |
Contributor
There was a problem hiding this comment.
Do we have a test for this?
Contributor
Author
There was a problem hiding this comment.
We have tests covering the kernel. But not specific to this wrapper. I just added one to make sure symm_mem_tensor is passed in rather than created inside the wrapper.
Ideally, we should avoid using such a wrapper though
stack-info: PR: #1824, branch: shunting314/stack/22
shunting314
force-pushed
the
shunting314/stack/22
branch
from
af5bbae to
0728d11
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
rendezvous only once for matmul reduce scatter
benchmarking results shows the helion kernel would be >10x slower if we don't have this fix.