Skip to content

Use a larger timeout setting to autotune distributed kernels#1800

Merged
shunting314 merged 1 commit intomainfrom
shunting314/stack/20
Mar 26, 2026
Merged

Use a larger timeout setting to autotune distributed kernels#1800
shunting314 merged 1 commit intomainfrom
shunting314/stack/20

Conversation

@shunting314
Copy link
Copy Markdown
Contributor

@shunting314 shunting314 commented Mar 24, 2026

Stacked PRs:


Use a larger timeout setting to autotune distributed kernels

These tests by design need more time. Use a larger timeout setting to make sure we gather reasonable signals.

@shunting314 shunting314 marked this pull request as draft March 24, 2026 17:51
@shunting314 shunting314 changed the base branch from shunting314/stack/19 to main March 24, 2026 17:51
shunting314 added a commit that referenced this pull request Mar 24, 2026
stack-info: PR: #1800, branch: shunting314/stack/20
@shunting314 shunting314 force-pushed the shunting314/stack/20 branch from 1ef7e44 to fbff8ac Compare March 24, 2026 17:52
@shunting314 shunting314 changed the base branch from main to shunting314/stack/19 March 24, 2026 17:52
@shunting314 shunting314 marked this pull request as ready for review March 24, 2026 17:52
@shunting314 shunting314 marked this pull request as draft March 24, 2026 19:03
@shunting314 shunting314 changed the base branch from shunting314/stack/19 to main March 24, 2026 19:03
shunting314 added a commit that referenced this pull request Mar 24, 2026
stack-info: PR: #1800, branch: shunting314/stack/20
@shunting314 shunting314 force-pushed the shunting314/stack/20 branch from fbff8ac to d1fbe5e Compare March 24, 2026 19:03
@shunting314 shunting314 changed the base branch from main to shunting314/stack/19 March 24, 2026 19:04
@shunting314 shunting314 marked this pull request as ready for review March 24, 2026 19:04
@shunting314 shunting314 marked this pull request as draft March 25, 2026 17:20
@shunting314 shunting314 changed the base branch from shunting314/stack/19 to main March 25, 2026 17:20
Copy link
Copy Markdown
Contributor

@jansel jansel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How long do distributed tests take in total now? 10m is a lot for a test, could we make the test faster?

@shunting314
Copy link
Copy Markdown
Contributor Author

How long do distributed tests take in total now? 10m is a lot for a test, could we make the test faster?

it takes about half a hour in total so far. The 10m timeout is mainly for an outlier that times out sometimes. Use 10m to make sure we don't have flaky tests. BTW, default timeout is 5m, so 10m is not that scary.

@shunting314 shunting314 marked this pull request as draft March 26, 2026 06:31
@shunting314 shunting314 changed the base branch from shunting314/stack/19 to main March 26, 2026 06:31
@shunting314 shunting314 force-pushed the shunting314/stack/20 branch from 6838074 to 51e1e7b Compare March 26, 2026 06:31
@shunting314 shunting314 changed the base branch from main to shunting314/stack/19 March 26, 2026 06:31
@shunting314 shunting314 marked this pull request as ready for review March 26, 2026 06:31
@shunting314 shunting314 marked this pull request as draft March 26, 2026 06:37
@shunting314 shunting314 changed the base branch from shunting314/stack/19 to main March 26, 2026 06:37
@shunting314 shunting314 force-pushed the shunting314/stack/20 branch from 51e1e7b to 864be33 Compare March 26, 2026 06:37
@shunting314 shunting314 changed the base branch from main to shunting314/stack/19 March 26, 2026 06:37
@shunting314 shunting314 marked this pull request as ready for review March 26, 2026 06:37
@shunting314 shunting314 marked this pull request as draft March 26, 2026 06:49
@shunting314 shunting314 changed the base branch from shunting314/stack/19 to main March 26, 2026 06:49
@shunting314 shunting314 force-pushed the shunting314/stack/20 branch from 864be33 to 2677be3 Compare March 26, 2026 06:49
@shunting314 shunting314 changed the base branch from main to shunting314/stack/19 March 26, 2026 06:49
@shunting314 shunting314 marked this pull request as ready for review March 26, 2026 06:49
@shunting314 shunting314 marked this pull request as draft March 26, 2026 06:51
@shunting314 shunting314 changed the base branch from shunting314/stack/19 to main March 26, 2026 06:51
@shunting314 shunting314 force-pushed the shunting314/stack/20 branch from 2677be3 to e2a058a Compare March 26, 2026 06:51
@shunting314 shunting314 changed the base branch from main to shunting314/stack/19 March 26, 2026 06:52
@shunting314 shunting314 marked this pull request as ready for review March 26, 2026 06:52
stack-info: PR: #1800, branch: shunting314/stack/20
@shunting314 shunting314 marked this pull request as draft March 26, 2026 06:54
@shunting314 shunting314 changed the base branch from shunting314/stack/19 to main March 26, 2026 06:54
@shunting314 shunting314 force-pushed the shunting314/stack/20 branch from e2a058a to 2805c68 Compare March 26, 2026 06:54
@shunting314 shunting314 marked this pull request as ready for review March 26, 2026 06:54
@shunting314 shunting314 merged commit 4b3e8b6 into main Mar 26, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants