Use a larger timeout setting to autotune distributed kernels#1800
Merged
shunting314 merged 1 commit intomainfrom Mar 26, 2026
Merged
Use a larger timeout setting to autotune distributed kernels#1800shunting314 merged 1 commit intomainfrom
shunting314 merged 1 commit intomainfrom
Conversation
shunting314
added a commit
that referenced
this pull request
Mar 24, 2026
stack-info: PR: #1800, branch: shunting314/stack/20
90cbe3e to
1ef7e44
Compare
This was referenced Mar 24, 2026
Merged
yf225
approved these changes
Mar 24, 2026
shunting314
added a commit
that referenced
this pull request
Mar 24, 2026
stack-info: PR: #1800, branch: shunting314/stack/20
1ef7e44 to
fbff8ac
Compare
shunting314
added a commit
that referenced
this pull request
Mar 24, 2026
stack-info: PR: #1800, branch: shunting314/stack/20
fbff8ac to
d1fbe5e
Compare
jansel
reviewed
Mar 26, 2026
Contributor
jansel
left a comment
There was a problem hiding this comment.
How long do distributed tests take in total now? 10m is a lot for a test, could we make the test faster?
Contributor
Author
it takes about half a hour in total so far. The 10m timeout is mainly for an outlier that times out sometimes. Use 10m to make sure we don't have flaky tests. BTW, default timeout is 5m, so 10m is not that scary. |
6838074 to
51e1e7b
Compare
51e1e7b to
864be33
Compare
864be33 to
2677be3
Compare
2677be3 to
e2a058a
Compare
stack-info: PR: #1800, branch: shunting314/stack/20
e2a058a to
2805c68
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
Use a larger timeout setting to autotune distributed kernels
These tests by design need more time. Use a larger timeout setting to make sure we gather reasonable signals.