Skip to content

avoid nvshmem symm-mem backend#1750

Merged
shunting314 merged 1 commit intomainfrom
shunting314/stack/10
Mar 25, 2026
Merged

avoid nvshmem symm-mem backend#1750
shunting314 merged 1 commit intomainfrom
shunting314/stack/10

Conversation

shunting314 added a commit that referenced this pull request Mar 19, 2026
stack-info: PR: #1750, branch: shunting314/stack/10
@shunting314 shunting314 force-pushed the shunting314/stack/10 branch from 22e66a1 to a272d26 Compare March 19, 2026 22:28
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Mar 19, 2026
@shunting314 shunting314 requested review from jansel and yf225 March 19, 2026 22:29
all-reduce test, and then clean up.
"""
# Only NVSHMEM backend implements `get_remote_tensor` for now.
symm_mem.set_backend("NVSHMEM")
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious should we explicitly set it to "cuda"?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's the default already

@shunting314 shunting314 marked this pull request as draft March 20, 2026 01:01
@shunting314 shunting314 changed the base branch from shunting314/stack/9 to main March 20, 2026 01:01
@shunting314 shunting314 changed the base branch from main to shunting314/stack/9 March 20, 2026 01:01
@shunting314 shunting314 marked this pull request as ready for review March 20, 2026 01:02
@shunting314 shunting314 marked this pull request as draft March 20, 2026 04:59
@shunting314 shunting314 changed the base branch from shunting314/stack/9 to main March 20, 2026 04:59
@shunting314 shunting314 changed the base branch from main to shunting314/stack/9 March 20, 2026 04:59
@shunting314 shunting314 marked this pull request as ready for review March 20, 2026 04:59
@shunting314 shunting314 marked this pull request as draft March 20, 2026 22:14
@shunting314 shunting314 changed the base branch from shunting314/stack/9 to main March 20, 2026 22:14
@shunting314 shunting314 force-pushed the shunting314/stack/10 branch from a272d26 to 9c95255 Compare March 20, 2026 22:14
@shunting314 shunting314 changed the base branch from main to shunting314/stack/9 March 20, 2026 22:15
@shunting314 shunting314 marked this pull request as ready for review March 20, 2026 22:15
@shunting314 shunting314 marked this pull request as draft March 20, 2026 22:33
@shunting314 shunting314 changed the base branch from shunting314/stack/9 to main March 20, 2026 22:33
@shunting314 shunting314 changed the base branch from main to shunting314/stack/9 March 20, 2026 22:33
@shunting314 shunting314 marked this pull request as ready for review March 23, 2026 22:35
@shunting314 shunting314 marked this pull request as draft March 23, 2026 22:38
@shunting314 shunting314 changed the base branch from shunting314/stack/9 to main March 23, 2026 22:38
@shunting314 shunting314 force-pushed the shunting314/stack/10 branch from fa244f2 to 84ac10a Compare March 23, 2026 22:38
@shunting314 shunting314 changed the base branch from main to shunting314/stack/9 March 23, 2026 22:38
@shunting314 shunting314 marked this pull request as ready for review March 23, 2026 22:38
@shunting314 shunting314 marked this pull request as draft March 24, 2026 00:17
@shunting314 shunting314 changed the base branch from shunting314/stack/9 to main March 24, 2026 00:17
@shunting314 shunting314 changed the base branch from main to shunting314/stack/9 March 24, 2026 00:17
@shunting314 shunting314 marked this pull request as ready for review March 24, 2026 00:18
@shunting314 shunting314 marked this pull request as draft March 24, 2026 00:37
@shunting314 shunting314 changed the base branch from shunting314/stack/9 to main March 24, 2026 00:37
@shunting314 shunting314 changed the base branch from main to shunting314/stack/9 March 24, 2026 00:37
@shunting314 shunting314 marked this pull request as ready for review March 24, 2026 00:37
@shunting314 shunting314 marked this pull request as draft March 24, 2026 04:18
@shunting314 shunting314 changed the base branch from shunting314/stack/9 to main March 24, 2026 04:18
@shunting314 shunting314 force-pushed the shunting314/stack/10 branch from 84ac10a to b943533 Compare March 24, 2026 04:19
@shunting314 shunting314 changed the base branch from main to shunting314/stack/3 March 24, 2026 04:19
@shunting314 shunting314 marked this pull request as ready for review March 24, 2026 04:19
@shunting314 shunting314 marked this pull request as draft March 24, 2026 04:43
@shunting314 shunting314 changed the base branch from shunting314/stack/3 to main March 24, 2026 04:43
@shunting314 shunting314 changed the base branch from main to shunting314/stack/3 March 24, 2026 04:44
@shunting314 shunting314 marked this pull request as ready for review March 24, 2026 04:44
@shunting314 shunting314 marked this pull request as draft March 24, 2026 04:57
@shunting314 shunting314 changed the base branch from shunting314/stack/3 to main March 24, 2026 04:57
@shunting314 shunting314 changed the base branch from main to shunting314/stack/3 March 24, 2026 04:57
stack-info: PR: #1750, branch: shunting314/stack/10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants