increase signal pad size for dist matmul kernels#1753
Merged
shunting314 merged 1 commit intomainfrom Mar 25, 2026
Merged
Conversation
shunting314
added a commit
that referenced
this pull request
Mar 20, 2026
stack-info: PR: #1753, branch: shunting314/stack/12
fe7948d to
e1957e5
Compare
This was referenced Mar 20, 2026
jansel
approved these changes
Mar 20, 2026
e1957e5 to
2532266
Compare
c7b0c4f to
c1de1ad
Compare
c1de1ad to
895c9d8
Compare
stack-info: PR: #1753, branch: shunting314/stack/12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
increase signal pad size for dist matmul kernels
the default signal pad size would cause out of bound global memory write if autotuner pick small block size. Increase the default for the matmul kernels. I'll improve autotuner to not autotuner beyond the signal pad size in a followup PR.