Skip to content

increase signal pad size for dist matmul kernels#1753

Merged
shunting314 merged 1 commit intomainfrom
shunting314/stack/12
Mar 25, 2026
Merged

increase signal pad size for dist matmul kernels#1753
shunting314 merged 1 commit intomainfrom
shunting314/stack/12

Conversation

@shunting314
Copy link
Copy Markdown
Contributor

@shunting314 shunting314 commented Mar 20, 2026

Stacked PRs:


increase signal pad size for dist matmul kernels

the default signal pad size would cause out of bound global memory write if autotuner pick small block size. Increase the default for the matmul kernels. I'll improve autotuner to not autotuner beyond the signal pad size in a followup PR.

shunting314 added a commit that referenced this pull request Mar 20, 2026
stack-info: PR: #1753, branch: shunting314/stack/12
@shunting314 shunting314 force-pushed the shunting314/stack/12 branch from fe7948d to e1957e5 Compare March 20, 2026 04:59
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Mar 20, 2026
@shunting314 shunting314 requested review from jansel and yf225 March 20, 2026 05:01
@shunting314 shunting314 marked this pull request as draft March 20, 2026 22:14
@shunting314 shunting314 changed the base branch from shunting314/stack/10 to main March 20, 2026 22:14
@shunting314 shunting314 force-pushed the shunting314/stack/12 branch from e1957e5 to 2532266 Compare March 20, 2026 22:14
@shunting314 shunting314 changed the base branch from main to shunting314/stack/10 March 20, 2026 22:15
@shunting314 shunting314 marked this pull request as ready for review March 20, 2026 22:15
@shunting314 shunting314 marked this pull request as draft March 20, 2026 22:33
@shunting314 shunting314 changed the base branch from shunting314/stack/10 to main March 20, 2026 22:33
@shunting314 shunting314 changed the base branch from main to shunting314/stack/10 March 20, 2026 22:33
@shunting314 shunting314 marked this pull request as ready for review March 20, 2026 22:34
@shunting314 shunting314 marked this pull request as draft March 20, 2026 22:49
@shunting314 shunting314 changed the base branch from shunting314/stack/10 to main March 20, 2026 22:49
@shunting314 shunting314 changed the base branch from main to shunting314/stack/10 March 20, 2026 22:49
@shunting314 shunting314 marked this pull request as ready for review March 20, 2026 22:49
@shunting314 shunting314 marked this pull request as draft March 20, 2026 22:57
@shunting314 shunting314 changed the base branch from shunting314/stack/10 to main March 20, 2026 22:57
@shunting314 shunting314 changed the base branch from main to shunting314/stack/10 March 20, 2026 22:57
@shunting314 shunting314 marked this pull request as ready for review March 20, 2026 22:57
@shunting314 shunting314 changed the base branch from main to shunting314/stack/10 March 24, 2026 00:17
@shunting314 shunting314 marked this pull request as ready for review March 24, 2026 00:18
@shunting314 shunting314 marked this pull request as draft March 24, 2026 00:37
@shunting314 shunting314 changed the base branch from shunting314/stack/10 to main March 24, 2026 00:37
@shunting314 shunting314 changed the base branch from main to shunting314/stack/10 March 24, 2026 00:37
@shunting314 shunting314 marked this pull request as ready for review March 24, 2026 00:37
@shunting314 shunting314 marked this pull request as draft March 24, 2026 04:18
@shunting314 shunting314 changed the base branch from shunting314/stack/10 to main March 24, 2026 04:19
@shunting314 shunting314 force-pushed the shunting314/stack/12 branch from c7b0c4f to c1de1ad Compare March 24, 2026 04:19
@shunting314 shunting314 changed the base branch from main to shunting314/stack/10 March 24, 2026 04:19
@shunting314 shunting314 marked this pull request as ready for review March 24, 2026 04:19
@shunting314 shunting314 marked this pull request as draft March 24, 2026 04:43
@shunting314 shunting314 changed the base branch from shunting314/stack/10 to main March 24, 2026 04:43
@shunting314 shunting314 changed the base branch from main to shunting314/stack/10 March 24, 2026 04:44
@shunting314 shunting314 marked this pull request as ready for review March 24, 2026 04:44
@shunting314 shunting314 marked this pull request as draft March 24, 2026 04:57
@shunting314 shunting314 changed the base branch from shunting314/stack/10 to main March 24, 2026 04:57
@shunting314 shunting314 changed the base branch from main to shunting314/stack/10 March 24, 2026 04:57
@shunting314 shunting314 marked this pull request as ready for review March 24, 2026 04:58
@shunting314 shunting314 marked this pull request as draft March 24, 2026 17:51
@shunting314 shunting314 changed the base branch from shunting314/stack/10 to main March 24, 2026 17:51
@shunting314 shunting314 force-pushed the shunting314/stack/12 branch from c1de1ad to 895c9d8 Compare March 24, 2026 17:52
@shunting314 shunting314 changed the base branch from main to shunting314/stack/10 March 24, 2026 17:52
@shunting314 shunting314 marked this pull request as ready for review March 24, 2026 17:52
@shunting314 shunting314 marked this pull request as draft March 24, 2026 19:03
@shunting314 shunting314 changed the base branch from shunting314/stack/10 to main March 24, 2026 19:03
stack-info: PR: #1753, branch: shunting314/stack/12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants