Skip to content

restrict to persistent pid for dist kernels#1772

Merged
shunting314 merged 1 commit intomainfrom
shunting314/stack/16
Mar 26, 2026
Merged

restrict to persistent pid for dist kernels#1772
shunting314 merged 1 commit intomainfrom
shunting314/stack/16

Conversation

@shunting314
Copy link
Copy Markdown
Contributor

@shunting314 shunting314 commented Mar 21, 2026

Copy link
Copy Markdown
Contributor

@jansel jansel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lints and tests?

@@ -0,0 +1,15 @@
from __future__ import annotations
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious should this be merged into helion/runtime/dist_utils.py added in #1771 ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'd better split compile time and runtime utils?

btw, I also plan to move other compiled time dist utils from _utils to this file

@shunting314 shunting314 marked this pull request as draft March 23, 2026 21:46
@shunting314 shunting314 changed the base branch from shunting314/stack/15 to main March 23, 2026 21:46
@shunting314 shunting314 force-pushed the shunting314/stack/16 branch from 4fb4be3 to 00453ba Compare March 23, 2026 21:46
@shunting314 shunting314 changed the base branch from main to shunting314/stack/15 March 23, 2026 21:47
@shunting314 shunting314 marked this pull request as ready for review March 23, 2026 21:47
@shunting314 shunting314 marked this pull request as draft March 23, 2026 22:34
@shunting314 shunting314 changed the base branch from shunting314/stack/15 to main March 23, 2026 22:34
@shunting314 shunting314 force-pushed the shunting314/stack/16 branch from 00453ba to 474d5b7 Compare March 23, 2026 22:35
@shunting314 shunting314 changed the base branch from main to shunting314/stack/15 March 23, 2026 22:35
@shunting314 shunting314 marked this pull request as ready for review March 23, 2026 22:35
@shunting314 shunting314 marked this pull request as draft March 23, 2026 22:38
@shunting314 shunting314 changed the base branch from shunting314/stack/15 to main March 23, 2026 22:38
@shunting314 shunting314 force-pushed the shunting314/stack/16 branch from 474d5b7 to 636a5b2 Compare March 23, 2026 22:38
@shunting314 shunting314 changed the base branch from main to shunting314/stack/15 March 23, 2026 22:38
@shunting314 shunting314 marked this pull request as ready for review March 23, 2026 22:39
@shunting314 shunting314 changed the base branch from shunting314/stack/15 to main March 24, 2026 17:51
@shunting314 shunting314 force-pushed the shunting314/stack/16 branch from c3aa73d to cdf4e12 Compare March 24, 2026 17:52
@shunting314 shunting314 changed the base branch from main to shunting314/stack/15 March 24, 2026 17:52
@shunting314 shunting314 marked this pull request as ready for review March 24, 2026 17:52
@shunting314 shunting314 marked this pull request as draft March 24, 2026 19:03
@shunting314 shunting314 changed the base branch from shunting314/stack/15 to main March 24, 2026 19:03
@shunting314 shunting314 force-pushed the shunting314/stack/16 branch from cdf4e12 to 5f19b7e Compare March 24, 2026 19:03
@shunting314 shunting314 changed the base branch from main to shunting314/stack/15 March 24, 2026 19:03
@shunting314 shunting314 marked this pull request as ready for review March 24, 2026 19:04
@shunting314 shunting314 requested review from jansel and yf225 March 24, 2026 19:04
@shunting314 shunting314 marked this pull request as draft March 25, 2026 17:19
@shunting314 shunting314 changed the base branch from shunting314/stack/15 to main March 25, 2026 17:19
@shunting314 shunting314 force-pushed the shunting314/stack/16 branch from 5f19b7e to c060a37 Compare March 25, 2026 17:20
@shunting314 shunting314 changed the base branch from main to shunting314/stack/15 March 25, 2026 17:20
@shunting314 shunting314 marked this pull request as ready for review March 25, 2026 17:20
@shunting314 shunting314 marked this pull request as draft March 25, 2026 17:24
@shunting314 shunting314 changed the base branch from shunting314/stack/15 to main March 25, 2026 17:24
@shunting314 shunting314 force-pushed the shunting314/stack/16 branch from c060a37 to 02fdc8a Compare March 25, 2026 17:25
@shunting314 shunting314 changed the base branch from main to shunting314/stack/15 March 25, 2026 17:25
@shunting314 shunting314 marked this pull request as ready for review March 25, 2026 17:25
stack-info: PR: #1772, branch: shunting314/stack/16
@shunting314 shunting314 marked this pull request as draft March 25, 2026 17:35
@shunting314 shunting314 changed the base branch from shunting314/stack/15 to main March 25, 2026 17:35
@shunting314 shunting314 force-pushed the shunting314/stack/16 branch from 02fdc8a to f555db0 Compare March 25, 2026 17:35
@shunting314 shunting314 marked this pull request as ready for review March 25, 2026 17:35
@shunting314
Copy link
Copy Markdown
Contributor Author

@jansel / @yf225 I've fixed the failed tests. The PR is ready to review again. CI green before rebase

@shunting314 shunting314 merged commit 386d2a3 into main Mar 26, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cap grid size for distributed kernel

3 participants