Skip to content

Add Backend.post_process_function_def hook#1851

Closed
aditvenk wants to merge 1 commit intoaditvenk/stack/20from
aditvenk/stack/17
Closed

Add Backend.post_process_function_def hook#1851
aditvenk wants to merge 1 commit intoaditvenk/stack/20from
aditvenk/stack/17

Conversation

@aditvenk
Copy link
Copy Markdown
Contributor

@aditvenk aditvenk commented Mar 27, 2026 •
edited
Loading

@aditvenk aditvenk force-pushed the aditvenk/stack/17 branch from 50c2a72 to d56d963 Compare March 27, 2026 22:35
@aditvenk aditvenk force-pushed the aditvenk/stack/16 branch from 8902395 to b8a13f6 Compare March 27, 2026 22:35
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Mar 27, 2026
This was referenced Mar 27, 2026
Merged
Merged
Merged
Merged
Merged
Closed
Open
Open
@aditvenk aditvenk marked this pull request as draft March 27, 2026 22:47
@aditvenk aditvenk changed the base branch from aditvenk/stack/16 to main March 27, 2026 22:47
@aditvenk aditvenk changed the base branch from main to aditvenk/stack/16 March 27, 2026 22:48
@aditvenk aditvenk marked this pull request as ready for review March 27, 2026 22:48
@aditvenk aditvenk requested review from jansel and oulgen March 27, 2026 22:54
@aditvenk aditvenk marked this pull request as draft March 28, 2026 00:11
@aditvenk aditvenk changed the base branch from aditvenk/stack/16 to main March 28, 2026 00:11
@aditvenk aditvenk force-pushed the aditvenk/stack/17 branch from d56d963 to 42d8d91 Compare March 28, 2026 00:12
@aditvenk aditvenk changed the base branch from main to aditvenk/stack/16 March 28, 2026 00:13
@aditvenk aditvenk marked this pull request as ready for review March 28, 2026 00:14
@aditvenk aditvenk marked this pull request as draft March 28, 2026 01:23
@aditvenk aditvenk changed the base branch from aditvenk/stack/16 to main March 28, 2026 01:23
@aditvenk aditvenk force-pushed the aditvenk/stack/17 branch from 42d8d91 to 12ea518 Compare March 28, 2026 01:24
@aditvenk aditvenk marked this pull request as ready for review March 28, 2026 01:26
@aditvenk aditvenk marked this pull request as draft March 28, 2026 01:38
@aditvenk aditvenk force-pushed the aditvenk/stack/17 branch 2 times, most recently from 484bc44 to 563343a Compare March 28, 2026 01:38
@aditvenk aditvenk mentioned this pull request Mar 28, 2026
Merged
@aditvenk aditvenk marked this pull request as ready for review March 28, 2026 02:46
@aditvenk aditvenk marked this pull request as draft March 28, 2026 04:44
@aditvenk aditvenk changed the base branch from aditvenk/stack/20 to main March 28, 2026 04:44
@aditvenk aditvenk force-pushed the aditvenk/stack/17 branch from 8afa526 to 33125a8 Compare March 28, 2026 04:44
@aditvenk aditvenk changed the base branch from main to aditvenk/stack/20 March 28, 2026 04:45
@aditvenk aditvenk mentioned this pull request Mar 28, 2026
Open
@aditvenk aditvenk marked this pull request as ready for review March 28, 2026 04:45
@aditvenk aditvenk marked this pull request as draft March 28, 2026 04:47
@aditvenk aditvenk changed the base branch from aditvenk/stack/20 to main March 28, 2026 04:47
@aditvenk aditvenk force-pushed the aditvenk/stack/17 branch from 33125a8 to 30417e7 Compare March 28, 2026 04:47
@aditvenk aditvenk changed the base branch from main to aditvenk/stack/20 March 28, 2026 04:47
@aditvenk aditvenk marked this pull request as ready for review March 28, 2026 04:48
@aditvenk aditvenk marked this pull request as draft March 28, 2026 06:46
@aditvenk aditvenk changed the base branch from aditvenk/stack/20 to main March 28, 2026 06:46
@aditvenk aditvenk force-pushed the aditvenk/stack/17 branch from 30417e7 to 4e000cb Compare March 28, 2026 06:46
@aditvenk aditvenk changed the base branch from main to aditvenk/stack/20 March 28, 2026 06:47
@aditvenk aditvenk marked this pull request as ready for review March 28, 2026 06:47
@aditvenk aditvenk marked this pull request as draft March 28, 2026 17:18
@aditvenk aditvenk changed the base branch from aditvenk/stack/20 to main March 28, 2026 17:18
@aditvenk aditvenk changed the base branch from main to aditvenk/stack/20 March 28, 2026 17:19
@aditvenk aditvenk marked this pull request as ready for review March 28, 2026 17:19
@aditvenk aditvenk marked this pull request as draft March 31, 2026 04:49
@aditvenk aditvenk changed the base branch from aditvenk/stack/20 to main March 31, 2026 04:49
@aditvenk aditvenk force-pushed the aditvenk/stack/17 branch from 4e000cb to 8676ca5 Compare March 31, 2026 04:50
@aditvenk aditvenk changed the base branch from main to aditvenk/stack/20 March 31, 2026 04:50
@aditvenk aditvenk marked this pull request as ready for review March 31, 2026 04:50
@aditvenk aditvenk marked this pull request as draft April 1, 2026 04:54
@aditvenk aditvenk changed the base branch from aditvenk/stack/20 to main April 1, 2026 04:54
@aditvenk
Add Backend.post_process_function_def hook
9560f26 
Add a post-processing hook called at the end of codegen_function_def
so backends can transform the function AST before it is returned.
The default implementation is identity.

stack-info: PR: #1851, branch: aditvenk/stack/17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jansel jansel jansel approved these changes

@oulgen oulgen Awaiting requested review from oulgen

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aditvenk @jansel