[metal] Add Metal codegen handlers for load, store, and mask_to#1854
Merged
[metal] Add Metal codegen handlers for load, store, and mask_to#1854
Conversation
b3e1da8 to
e8fe296
Compare
fcdc04d to
9051e3d
Compare
This was referenced Mar 27, 2026
This was referenced Mar 27, 2026
9051e3d to
39be6fc
Compare
39be6fc to
d4742e4
Compare
d4742e4 to
ebc77e3
Compare
362154b to
665a413
Compare
665a413 to
22b55f9
Compare
22b55f9 to
b92b019
Compare
b92b019 to
da3554f
Compare
jansel
reviewed
Mar 30, 2026
Contributor
jansel
left a comment
There was a problem hiding this comment.
Is there test coverage for this?
Contributor
Author
In follow-up PR in the stack: #1794 (copy kernels) |
da3554f to
b7cb9eb
Compare
jansel
approved these changes
Apr 8, 2026
Add @_decorators.codegen handlers for the Metal backend:
- load("metal"): delegates to PointerIndexingStrategy.codegen_load
- store("metal"): delegates to PointerIndexingStrategy.codegen_store
- _mask_to("metal"): applies tile masks via IfExp
stack-info: PR: #1854, branch: aditvenk/stack/20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
[metal] Add Metal codegen handlers for load, store, and mask_to
Add @_decorators.codegen handlers for the Metal backend: